Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for anyoneof object primitive #894

Merged
merged 5 commits into from
Jul 22, 2024
Merged

Add support for anyoneof object primitive #894

merged 5 commits into from
Jul 22, 2024

Conversation

sserrata
Copy link
Member

Description

Addresses issue reported in #889

This adds fix to v2.0.0 branch. Will port to v3 and address the remaining formatting issues.

@sserrata sserrata added bug Something isn't working v2.0.0 labels Jul 22, 2024
@sserrata sserrata self-assigned this Jul 22, 2024
Copy link

github-actions bot commented Jul 22, 2024

Visit the preview URL for this PR (updated for commit 6009db0):

https://docusaurus-openapi-36b86--pr894-zo65wk28.web.app

(expires Wed, 21 Aug 2024 16:39:18 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@sserrata
Copy link
Member Author

Results of test:

Screenshot 2024-07-22 at 11 15 53 AM

@sserrata
Copy link
Member Author

The particular way we are parsing and handling data types required that we handle object primitives separate from the others.

Here's what I was seeing:

Screenshot 2024-07-22 at 11 30 52 AM

To avoid this, we check to make sure there are no properties, allOf or items present in the schema before handling as a true primitive.

@sserrata sserrata merged commit 7fd1f42 into v2.0.0 Jul 22, 2024
11 checks passed
@sserrata sserrata deleted the anyoneof-object branch July 22, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant