-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add CSS Methodology #960
add CSS Methodology #960
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests and there are no merge conflicts. The process helps maintain accurate and well-formatted documentation and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- This is good
- Please put the images in new
static/img/markdown/ui-ux
directory for consistency
Thanks! |
What kind of change does this PR introduce?
This PR suggests a CSS Methodology to be followed accross all components/screens
Issue Number:
Fixes #959
Did you add tests for your changes?
Yes
Snapshots/Videos:
SearchBar
Modal
Tabs and Table
If relevant, did you update the documentation?
Yes
Summary
Since all CSS files are being merged into a single global stylesheet, identifying common elements like modals, tables, and tabs and creating reusable CSS classes is important. The goal is to ensure consistency across all components and screens by defining a structured CSS methodology.
Other information
Have you read the contributing guide?