Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes] Code Coverage: Create tests for store.tsx #299

Conversation

SiddheshKukade
Copy link
Member

@SiddheshKukade SiddheshKukade commented Mar 19, 2022

What kind of change does this PR introduce?
Added Testcases for src/state/index.ts file

Issue Number:
#277

Fixes #277

Did you add tests for your changes?
Yes I have added a testfile

Summary
I have added a store.test.tsx file required for the issue #277 for Gsoc2022

Does this PR introduce a breaking change?
No

SnapShots

image

Have you read the contributing guide?
Yes

@SiddheshKukade
Copy link
Member Author

Please let me know if I can improve and also the state.text.tsx file is added on the 3rd commit the first 2 commits are from another pull request #296

@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2022

Codecov Report

Merging #299 (ffe1a20) into develop (b462cca) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #299   +/-   ##
========================================
  Coverage    40.22%   40.22%           
========================================
  Files           45       45           
  Lines          711      711           
  Branches       149      149           
========================================
  Hits           286      286           
  Misses         410      410           
  Partials        15       15           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@SiddheshKukade SiddheshKukade changed the title TEST : src/state/store.tsx testing added [Fixes] Code Coverage: Create tests for store.tsx Mar 19, 2022
@palisadoes
Copy link
Contributor

You have submitted a PR without the issue being assigned. I just assigned the issue and realized the PR was in the queue for some hours. Please follow the process. We need to make everyone have a chance to participate. If you do this in future, the PR will be closed.

Copy link
Contributor

@palisadoes palisadoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please get the coverage up to 100%. At that point the PR will be reviewed.

@SiddheshKukade
Copy link
Member Author

You have submitted a PR without the issue being assigned. I just assigned the issue and realized the PR was in the queue for some hours. Please follow the process. We need to make everyone have a chance to participate. If you do this in the future, the PR will be closed.

I apologize, sir , this will not be repeated

@yasharth291
Copy link
Contributor

there is no increase in the codebase so the pr makes no sense i guess

@SiddheshKukade
Copy link
Member Author

SiddheshKukade commented Mar 20, 2022

there is no increase in the codebase so the pr makes no sense i guess

wait i am improving the code

@SiddheshKukade
Copy link
Member Author

@palisadoes @yasharth291 I have a simple doubt
On my machine when I run

 yarn test --watchAll=false --coverage

I get the following coverage
100% coverage
image

But in this Pull request the CODECOV shows following]
40% coverage only
image

please correct me If I'm going wrong at something

@Sagar2366 Sagar2366 added the test Testing application label Mar 22, 2022
@yasharth291
Copy link
Contributor

we have re-run the codecov on this you can close this one and open it again

@SiddheshKukade
Copy link
Member Author

ok @yasharth291 sir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Testing application
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code Coverage: Create tests for store.ts
5 participants