-
-
Notifications
You must be signed in to change notification settings - Fork 866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fixes] Code Coverage: Create tests for store.tsx #299
[Fixes] Code Coverage: Create tests for store.tsx #299
Conversation
Please let me know if I can improve and also the |
Codecov Report
@@ Coverage Diff @@
## develop #299 +/- ##
========================================
Coverage 40.22% 40.22%
========================================
Files 45 45
Lines 711 711
Branches 149 149
========================================
Hits 286 286
Misses 410 410
Partials 15 15 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
You have submitted a PR without the issue being assigned. I just assigned the issue and realized the PR was in the queue for some hours. Please follow the process. We need to make everyone have a chance to participate. If you do this in future, the PR will be closed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please get the coverage up to 100%. At that point the PR will be reviewed.
I apologize, sir , this will not be repeated |
there is no increase in the codebase so the pr makes no sense i guess |
wait i am improving the code |
@palisadoes @yasharth291 I have a simple doubt yarn test --watchAll=false --coverage
I get the following coverage But in this Pull request the CODECOV shows following] please correct me If I'm going wrong at something |
we have re-run the codecov on this you can close this one and open it again |
ok @yasharth291 sir |
What kind of change does this PR introduce?
Added Testcases for src/state/index.ts file
Issue Number:
#277
Fixes #277
Did you add tests for your changes?
Yes I have added a testfile
Summary
I have added a store.test.tsx file required for the issue #277 for Gsoc2022
Does this PR introduce a breaking change?
No
SnapShots
Have you read the contributing guide?
Yes