DEPRECATION: Replace or update packages relying on punycode #2862 #2871

khushipatil1523 · 2024-12-25T18:06:18Z

What kind of change does this PR introduce?

This PR will Replace or update packages relying on punycode #2862

Issue Number:

#2862

Did you update for packages?

Yes

Summary by CodeRabbit

New Features
- Added a new dependency for improved linting configuration.
Updates
- Updated multiple development dependencies to enhance project setup and performance.
Configuration Changes
- Modified lint-staged configuration to include TypeScript and JSON files for linting.
- Introduced an overrides section for package version management.
- Enhanced ESLint configuration by specifying files to ignore during linting.

coderabbitai · 2024-12-25T18:06:24Z

Walkthrough

The pull request focuses on updating the package.json file for the talawa-admin project. The changes include adding a new dependency, updating several existing dependency versions, introducing an overrides section for the punycode package, and modifying the lint-staged configuration to include additional ESLint fixing for TypeScript and JSON files. Additionally, the .eslintignore file has been removed, and corresponding ignore settings have been added to the eslint.config.js file.

Changes

File	Change Summary
`package.json`	- Added `ajv` dependency `^8.17.1` - Updated `@vitest/coverage-istanbul` to `^2.1.8` - Updated `eslint` to `^9.17.0` - Downgraded `jest-preview` to `^0.2.3` - Updated `vitest` to `^2.1.8` - Added `overrides` for `punycode` to version `2.3.0` - Modified `lint-staged` to include `*/.{ts, tsx, json}` with `eslint --fix`
`.eslintignore`	- Removed file, leading to potential linting of previously ignored files.
`eslint.config.js`	- Added `ignores` array to specify files to be ignored by ESLint: `src/components/CheckIn/tagTemplate.ts`, `package.json`, `package-lock.json`, and `tsconfig.json`.

Possibly related issues

#2862 DEPRECATION: Replace or update packages relying on punycode
- The added overrides for punycode and dependency updates directly address the deprecation concerns raised in this issue.

Possibly related PRs

feat!: Migrate Testing Framework from Jest to Vitest #2457: This PR updates the package.json file, which is directly related to the changes made in the main PR regarding dependency management and updates.
Refactor jest to vitest #2832 #2861: This PR refactors tests from Jest to Vitest, which aligns with the changes in the main PR that involve updates to the testing framework and related configurations.
Refactor src/components/UserProfileSettings/* from Jest to Vitest #2869: Similar to Refactor jest to vitest #2832 #2861, this PR also focuses on migrating tests from Jest to Vitest, indicating a broader effort to standardize the testing framework across the project.
Migrated src/components/ChangeLanguageDropdown from Jest to Vitest #2909: This PR migrates the ChangeLanguageDropdown component tests from Jest to Vitest, further supporting the transition to the new testing framework mentioned in the main PR.

Suggested labels

test, ignore-sensitive-files-pr

Suggested reviewers

palisadoes
pranshugupta54
AVtheking
GlenDsza
Doraemon012

Poem

🐰 Hop, hop, dependencies dance!
Versions bump with a playful glance
ESLint fixes, configs align
Punycode's path now starts to shine
A package update, clean and bright 🔧

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ca918f1 and 2e915fd.

⛔ Files ignored due to path filters (1)

package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (3)

.eslintignore (0 hunks)
eslint.config.js (1 hunks)
package.json (4 hunks)

💤 Files with no reviewable changes (1)

.eslintignore

✅ Files skipped from review due to trivial changes (1)

eslint.config.js

🚧 Files skipped from review as they are similar to previous changes (1)

package.json

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2024-12-25T18:06:41Z

Our Pull Request Approval Process

Thanks for contributing!

Testing Your Code

Remember, your PRs won't be reviewed until these criteria are met:

We don't merge PRs with poor code quality.
1. Follow coding best practices such that CodeRabbit.ai approves your PR.
We don't merge PRs with failed tests.
1. When tests fail, click on the Details link to learn more.
2. Write sufficient tests for your changes (CodeCov Patch Test). Your testing level must be better than the target threshold of the repository
3. Tests may fail if you edit sensitive files. Ask to add the ignore-sensitive-files-pr label if the edits are necessary.
We cannot merge PRs with conflicting files. These must be fixed.

Our policies make our code better.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

comments in this PR or
our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

arbitrators of future discussions with other contributors about the validity of your changes
point of contact for evaluating the validity of your work
person who verifies matching issues by others that should be closed.
person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

PRs with issues not assigned to you will be closed by the reviewer
Fix the first comment in the PR so that each issue listed automatically closes

Other

🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
Read the CONTRIBUTING.md file make

coderabbitai

Actionable comments posted: 1

🔭 Outside diff range comments (1)

package.json (1)
Line range hint 173-177: Fix lint-staged file pattern syntax

The file patterns in lint-staged configuration have incorrect spacing which could cause the hooks to fail. Remove spaces after commas in the file extensions.

Apply this diff to fix the syntax:
  "lint-staged": {
-   "**/*.{ts, tsx, json, scss, css}": [
+   "**/*.{ts,tsx,json,scss,css}": [
      "prettier --write"
    ],
-   "**/*.{ts, tsx, json}": "eslint --fix"
+   "**/*.{ts,tsx,json}": "eslint --fix"
  }

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 471f113 and 70e687f.

⛔ Files ignored due to path filters (1)

package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (1)

package.json (4 hunks)

🔇 Additional comments (3)

package.json (3)

154-154: Verify jest-preview version downgrade

The downgrade of jest-preview from 0.3.1 to 0.2.3 seems unintentional. This could potentially reintroduce fixed bugs or remove needed features.

178-180: LGTM: Punycode override addresses deprecation

The addition of the punycode override to version 2.3.0 effectively addresses the deprecation warning mentioned in issue #2862. This ensures all nested dependencies use a stable version of punycode.

142-142: Review breaking changes in eslint v9

The major version bump of eslint (8.49.0 -> 9.17.0) may introduce breaking changes. Please ensure:

All existing eslint rules are compatible
CI pipeline passes with the new version
Development team is aware of any rule changes

package.json

palisadoes · 2024-12-25T19:47:00Z

Please fix the failing tests

…github.com/khushipatil1523/talawa-admin into updating-pakages-PalisadoesFoundation#2862

palisadoes · 2024-12-26T12:03:26Z

Please fix the conflicting file

palisadoes · 2024-12-27T06:54:24Z

You don't have to close the PR when there is a conflicting file.

Pull the latest upstream/develop-postgres
merge it with your local branch
fix the conflicts in your IDE
commit
push to the changes to your origin

packages updated

70e687f

coderabbitai bot requested changes Dec 25, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

Update package.json

ca918f1

coderabbitai bot previously approved these changes Dec 25, 2024

View reviewed changes

khushipatil1523 added 3 commits December 26, 2024 04:55

Fix ESLint warnings and update configuration

0ba3839

Merge branch 'updating-pakages-PalisadoesFoundation#2862' of https://…

8e65949

…github.com/khushipatil1523/talawa-admin into updating-pakages-PalisadoesFoundation#2862

packages updated

2e915fd

khushipatil1523 dismissed coderabbitai[bot]’s stale review via 2e915fd December 26, 2024 06:54

coderabbitai bot approved these changes Dec 26, 2024

View reviewed changes

khushipatil1523 closed this Dec 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DEPRECATION: Replace or update packages relying on punycode #2862 #2871

DEPRECATION: Replace or update packages relying on punycode #2862 #2871

khushipatil1523 commented Dec 25, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 25, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

github-actions bot commented Dec 25, 2024

coderabbitai bot left a comment

palisadoes commented Dec 25, 2024

palisadoes commented Dec 26, 2024

palisadoes commented Dec 27, 2024

DEPRECATION: Replace or update packages relying on punycode #2862 #2871

DEPRECATION: Replace or update packages relying on punycode #2862 #2871

Conversation

khushipatil1523 commented Dec 25, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented Dec 25, 2024 • edited Loading

Walkthrough

Changes

Possibly related issues

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

github-actions bot commented Dec 25, 2024

Our Pull Request Approval Process

Testing Your Code

Reviewers

Reviewing Your Code

CONTRIBUTING.md

Other

coderabbitai bot left a comment

Choose a reason for hiding this comment

palisadoes commented Dec 25, 2024

palisadoes commented Dec 26, 2024

palisadoes commented Dec 27, 2024

khushipatil1523 commented Dec 25, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 25, 2024 •

edited

Loading