Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CSS files in src/screens/BlockUser #2502

Closed
AVtheking opened this issue Nov 30, 2024 · 9 comments
Closed

Refactor CSS files in src/screens/BlockUser #2502

AVtheking opened this issue Nov 30, 2024 · 9 comments
Assignees
Labels
feature request good first issue Good for newcomers ui/ux issue related and being worked with the figma file of the Admin UI

Comments

@AVtheking
Copy link
Contributor

AVtheking commented Nov 30, 2024

Refactor CSS files in src/screens/BlockUser

To improve the UI/UX of Talawa-Admin we have been working on:

  1. making the application more suitable to color blind users
  2. streamlining all CSS into a single global file

Additional information:

  1. The foundational work for this was completed in this PR:
  2. The desired single CSS file is:
    • src/style/app.module.css

Color Blindness

  1. We are migrating away from the green theme as part of our support for color blind users.
  2. Take cues from other similar elements in this file and the PR mentioned in the issue.
    1. https://www.figma.com/design/dmKt00m9GVSeA1nebnkxql/Untitled?node-id=0-1&node-type=canvas&t=TPzfh1DE9IxjzsEe-0
  3. Use a variable instead. There are appropriate blue/grey colors that have been used in other screens

The challenge:

The goal is to convert the CSS file in this subdirectory and all the components related to this screen to use this new design pattern. This means that:

  1. All CSS files in this subdirectory and all the CSS files in related components must be merged into the global CSS file using pre-existing CSS.
  2. All CSS files in this subdirectory and all the CSS files in related components must be deleted after the merge.
  3. The remaining relevant files in this subdirectory must only reference the global CSS file.
  4. All the CSS files in the related components of this subdirectory must adhere to the same guidelines.
@github-actions github-actions bot added refactor Refactor the code to improve its quality ui/ux issue related and being worked with the figma file of the Admin UI unapproved good first issue Good for newcomers labels Nov 30, 2024
@AVtheking AVtheking changed the title Refactor CSS files in screens Refactor CSS files in src/screens/BlockUser Nov 30, 2024
@Abhinav232004
Copy link
Contributor

@palisadoes Can you please assign this issue to me?

@palisadoes palisadoes removed the refactor Refactor the code to improve its quality label Nov 30, 2024
@palisadoes palisadoes moved this from Backlog to In progress in Talawa Admin - Refactoring Dec 1, 2024
Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Dec 23, 2024
@Cioppolo14
Copy link
Contributor

Unassigning due to no activity.

@gurramkarthiknetha
Copy link
Contributor

If no one is currently working on this issue, I would like to take it on. Please assign it to me.

@maheshxsharmask
Copy link

Hi, can I work on this issue? I am a beginner and would like to contribute.

@palisadoes
Copy link
Contributor

With this issue we are migrating from the previous green based color scheme where the #31bb6b color was used for many elements to one using a color scheme similar to that of Gmail.

This makes the app more usable for people with red/green color blindness

When making your changes, make the effort to use pre-existing colors in the src/style/app.module.css file.

Copy link

github-actions bot commented Jan 6, 2025

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Jan 6, 2025
@Cioppolo14
Copy link
Contributor

Unassigning due to inactivity and/or no submitted PR. Others need to get a chance. Please let us know whether you want to be reassigned before someone else requests assignment or select another issue.

@gurramkarthiknetha
Copy link
Contributor

i would like to work on this @Cioppolo14 could you assign me this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request good first issue Good for newcomers ui/ux issue related and being worked with the figma file of the Admin UI
Projects
Status: Done
Development

No branches or pull requests

6 participants