Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade packages vitest and @vitest/coverage-v8 #2097

Closed
palisadoes opened this issue Jul 15, 2024 · 10 comments
Closed

Upgrade packages vitest and @vitest/coverage-v8 #2097

palisadoes opened this issue Jul 15, 2024 · 10 comments
Assignees
Labels
bug Something isn't working dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation good first issue Good for newcomers parent Parent issue security Security fix test Testing application

Comments

@palisadoes
Copy link
Contributor

Rationale

  1. This was previously attempted by the automated dependabot job but the PR tests failed.
  2. This issue has been created to fix the issue as there may be multiple dependency requirements that need updating

This is a major revision upgrade and many files may need to be updated to the new syntax, functions, methods and classes

Task

  1. Upgrade vitest and @vitest/coverage-v8. These dependencies needed to be updated together.
  2. Remove this package if it is:
    1. unused
    2. unnecessary. For example:
      1. the functionality can be maintained by using another package we are already using,
      2. If we are using only one function or class in the package you can consider replacing it with code that resides in this repository
      3. It is used by a feature that the end user is unlikely to ever use

Background Failing PRs

Release Note Details

Bumps vitest and @vitest/coverage-v8. These dependencies needed to be updated together.
Updates vitest from 1.6.0 to 2.0.3

Release notes

Sourced from vitest's releases.

v2.0.3

   🚀 Features

   🐞 Bug Fixes

    View changes on GitHub

v2.0.2

   🐞 Bug Fixes

   🏎 Performance

    View changes on GitHub

v2.0.1

   🐞 Bug Fixes

    View changes on GitHub

v2.0.0

... (truncated)

Commits
  • 81b8d67 chore: release v2.0.3
  • 09dc75c chore(deps): update dependency @​edge-runtime/vm to v4 (#6047)
  • f851982 fix: --inspect-brk stop on Windows (#6110)
  • 99a12ae chore: release v2.0.2
  • 80a43d5 fix(browser): inline pretty-format and replace picocolors with tinyrainbow (#...
  • 7012f8c docs: add env documentation (#6063)
  • 16eb6c8 chore: release v2.0.1
  • 4b03e72 fix(browser): correctly inherit browser config in a workspace (#6054)
  • 4d5597d fix(vitest): print only running files, not every file (#6052)
  • 1b150a3 chore: release v2.0.0
  • Additional commits viewable in compare view

Updates @vitest/coverage-v8 from 1.6.0 to 2.0.3

Release notes

Sourced from @​vitest/coverage-v8's releases.

v2.0.3

   🚀 Features

   🐞 Bug Fixes

    View changes on GitHub

v2.0.2

   🐞 Bug Fixes

   🏎 Performance

    View changes on GitHub

v2.0.1

   🐞 Bug Fixes

    View changes on GitHub

v2.0.0

... (truncated)

Commits
  • 81b8d67 chore: release v2.0.3
  • 99a12ae chore: release v2.0.2
  • 80a43d5 fix(browser): inline pretty-format and replace picocolors with tinyrainbow (#...
  • 16eb6c8 chore: release v2.0.1
  • 1b150a3 chore: release v2.0.0
  • 5611895 chore: release v2.0.0-beta.13
  • 368c137 fix(coverage): remove work-around for implicit else (#6014)
  • 05d5f38 chore(deps): update all non-major dependencies (#5957)
  • 169bc1f fix(coverage): support overriding exclude (#5997)
  • cd9cc6b chore: release v2.0.0-beta.12
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
@palisadoes palisadoes added bug Something isn't working good first issue Good for newcomers security Security fix dependencies Pull requests that update a dependency file labels Jul 15, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation parent Parent issue test Testing application unapproved labels Jul 15, 2024
@govindsingh3477
Copy link
Contributor

can you please assign this to me .

@sanjanaynvsdl
Copy link

Hey @palisadoes can you please assign this issue to me?

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Aug 10, 2024
@palisadoes
Copy link
Contributor Author

Unassigning. No active PRs. No activity.

@github-actions github-actions bot removed the no-issue-activity No issue activity label Aug 12, 2024
@ManjariRathore
Copy link
Contributor

ManjariRathore commented Aug 12, 2024

Hello @palisadoes, @varshith257

I would like to work on this issue, if possible can you assign this to me. I will raise a draft PR asap.

@Cioppolo14
Copy link
Contributor

@ManjariRathore you are requesting to work on many issues. You can only be assigned 2 at a time. Please indicate which 2 are your priorities. Thank you.

@ManjariRathore
Copy link
Contributor

Hey @Cioppolo14
Thank you for the update. I would like to prioritize the following two issues for now:

Upgrade packages vitest and @vitest/coverage-v8 #2097
Upgrade package pdfme from 1.2.6 to 4.0.2 #2027
Please feel free to assign me from the others, and I'll be happy to pick them up later once these are resolved.
Also i have already raised a PR for the issue #2136

Thanks again!

@Cioppolo14
Copy link
Contributor

@ManjariRathore Thank you! This is very helpful. Since you have 2136 & 2097 assigned now, I will not assign anymore. As soon as a PR is merged, comment on the next one you'd like to do, and we can go from there. I appreciate your initiative.

@ManjariRathore
Copy link
Contributor

@Cioppolo14 I see that these packages are not in use in the codebase and do not exist in the dependencies. How should we proceed in this case?

@palisadoes
Copy link
Contributor Author

Closing. Wrong repo. A new issue has been created.

@palisadoes palisadoes closed this as not planned Won't fix, can't repro, duplicate, stale Aug 13, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Talawa-Admin (Tests) Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation good first issue Good for newcomers parent Parent issue security Security fix test Testing application
Projects
Archived in project
Development

No branches or pull requests

6 participants