Addition test cases added to improve code coverage (#3407)

PalisadoesFoundation · Jan 24, 2025 · 6a4eede · 6a4eede
1 parent a8f2b25
commit 6a4eede
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 25 deletions.
diff --git a/src/screens/MemberDetail/MemberDetail.spec.tsx b/src/screens/MemberDetail/MemberDetail.spec.tsx
@@ -104,19 +104,13 @@ describe('MemberDetail', () => {
 
   test('should render the elements', async () => {
     renderMemberDetailScreen(link1);
-
     await wait();
 
     expect(screen.queryByText('Loading data...')).not.toBeInTheDocument();
     expect(screen.getAllByText(/Email/i)).toBeTruthy();
     expect(screen.getAllByText(/First name/i)).toBeTruthy();
     expect(screen.getAllByText(/Last name/i)).toBeTruthy();
-    // expect(screen.getAllByText(/Language/i)).toBeTruthy();
-    // expect(screen.getByText(/Plugin creation allowed/i)).toBeInTheDocument();
-    // expect(screen.getAllByText(/Joined on/i)).toBeTruthy();
-    // expect(screen.getAllByText(/Joined On/i)).toHaveLength(1);
     expect(screen.getAllByText(/Profile Details/i)).toHaveLength(1);
-    // expect(screen.getAllByText(/Actions/i)).toHaveLength(1);
     expect(screen.getAllByText(/Contact Information/i)).toHaveLength(1);
     expect(screen.getAllByText(/Events Attended/i)).toHaveLength(2);
   });
@@ -255,6 +249,25 @@ describe('MemberDetail', () => {
     expect(userImage.getAttribute('src')).toBe(user?.image);
   });
 
+  test('image upload and display works correctly', async () => {
+    renderMemberDetailScreen(link2);
+
+    await waitFor(() => {
+      expect(screen.getByTestId('organisationImage')).toBeInTheDocument();
+    });
+    const file = new File(['hello'], 'hello.png', { type: 'image/png' });
+    const fileInput = screen.getByTestId(
+      'organisationImage',
+    ) as HTMLInputElement;
+    fireEvent.change(fileInput, { target: { files: [file] } });
+
+    await waitFor(() => {
+      const userImage = screen.getByTestId('userImagePresent');
+      expect(userImage).toBeInTheDocument();
+      expect(userImage.getAttribute('src')).toContain('data:image/png;base64');
+    });
+  });
+
   test('resetChangesBtn works properly', async () => {
     renderMemberDetailScreen(link1);
 

diff --git a/src/screens/MemberDetail/MemberDetail.tsx b/src/screens/MemberDetail/MemberDetail.tsx
@@ -42,8 +42,7 @@ type MemberDetailProps = {
 /**
  * MemberDetail component is used to display the details of a user.
  * It also allows the user to update the details. It uses the UPDATE_USER_MUTATION to update the user details.
- * It uses the USER_DETAILS query to get the user details. It uses the useLocalStorage hook to store the user
- *  details in the local storage.
+ * It uses the USER_DETAILS query to get the user details. It uses the useLocalStorage hook to store the user details in the local storage.
  * @param id - The id of the user whose details are to be displayed.
  * @returns  React component
  *
@@ -87,6 +86,7 @@ const MemberDetail: React.FC<MemberDetailProps> = ({ id }): JSX.Element => {
   });
   const handleDateChange = (date: Dayjs | null): void => {
     if (date) {
+      console.log('formated', dayjs(date).format('YYYY-MM-DD'));
       setisUpdated(true);
       setFormState((prevState) => ({
         ...prevState,
@@ -95,7 +95,6 @@ const MemberDetail: React.FC<MemberDetailProps> = ({ id }): JSX.Element => {
     }
   };
 
-  /*istanbul ignore next*/
   const handleEditIconClick = (): void => {
     fileInputRef.current?.click();
   };
@@ -143,19 +142,16 @@ const MemberDetail: React.FC<MemberDetailProps> = ({ id }): JSX.Element => {
   const tagsAssigned =
     userData?.user?.tagsAssignedWith.edges.map(
       (edge: { node: InterfaceTagData; cursor: string }) => edge.node,
-    ) ?? /* istanbul ignore next */ [];
+    ) ?? [];
 
   const loadMoreAssignedTags = (): void => {
     fetchMoreAssignedTags({
       variables: {
         first: TAGS_QUERY_DATA_CHUNK_SIZE,
-        after:
-          user?.user?.user?.tagsAssignedWith?.pageInfo?.endCursor ??
-          /* istanbul ignore next */
-          null,
+        after: user?.user?.user?.tagsAssignedWith?.pageInfo?.endCursor ?? null,
       },
       updateQuery: (prevResult, { fetchMoreResult }) => {
-        if (!fetchMoreResult) /* istanbul ignore next */ return prevResult;
+        if (!fetchMoreResult) return prevResult;
 
         return {
           user: {
@@ -193,7 +189,6 @@ const MemberDetail: React.FC<MemberDetailProps> = ({ id }): JSX.Element => {
       toggleUnassignUserTagModal();
       toast.success(t('successfullyUnassigned'));
     } catch (error: unknown) {
-      /* istanbul ignore next */
       if (error instanceof Error) {
         toast.error(error.message);
       }
@@ -211,7 +206,6 @@ const MemberDetail: React.FC<MemberDetailProps> = ({ id }): JSX.Element => {
     e: React.ChangeEvent<HTMLInputElement | HTMLSelectElement>,
   ): Promise<void> => {
     const { name, value } = e.target;
-    /*istanbul ignore next*/
     if (
       name === 'photo' &&
       'files' in e.target &&
@@ -251,7 +245,6 @@ const MemberDetail: React.FC<MemberDetailProps> = ({ id }): JSX.Element => {
             ...formState,
           },
         });
-        /* istanbul ignore next */
         if (data) {
           setisUpdated(false);
           if (getItem('id') === currentUrl) {
@@ -264,18 +257,17 @@ const MemberDetail: React.FC<MemberDetailProps> = ({ id }): JSX.Element => {
         }
       } catch (error: unknown) {
         if (error instanceof Error) {
+          console.log('the error is ', error.message);
           errorHandler(t, error);
         }
       }
     } catch (error: unknown) {
-      /* istanbul ignore next */
       if (error instanceof Error) {
         errorHandler(t, error);
       }
     }
   };
   const resetChanges = (): void => {
-    /*istanbul ignore next*/
     setFormState({
       firstName: userData?.user?.firstName || '',
       lastName: userData?.user?.lastName || '',
@@ -351,9 +343,8 @@ const MemberDetail: React.FC<MemberDetailProps> = ({ id }): JSX.Element => {
                       role="button"
                       aria-label="Edit profile picture"
                       tabIndex={0}
-                      onKeyDown={
-                        /*istanbul ignore next*/
-                        (e) => e.key === 'Enter' && handleEditIconClick()
+                      onKeyDown={(e) =>
+                        e.key === 'Enter' && handleEditIconClick()
                       }
                     />
                   </div>
@@ -416,7 +407,7 @@ const MemberDetail: React.FC<MemberDetailProps> = ({ id }): JSX.Element => {
                     placeholder={tCommon('lastName')}
                   />
                 </Col>
-                <Col md={6}>
+                <Col md={6} data-testid="gender">
                   <label htmlFor="gender" className="form-label">
                     {t('gender')}
                   </label>
@@ -633,7 +624,6 @@ const MemberDetail: React.FC<MemberDetailProps> = ({ id }): JSX.Element => {
                   next={loadMoreAssignedTags}
                   hasMore={
                     userData?.user?.tagsAssignedWith.pageInfo.hasNextPage ??
-                    /* istanbul ignore next */
                     false
                   }
                   loader={<InfiniteScrollLoader />}