-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LUFA as submodule #6
Conversation
Don't pull this in for now! I can't seem to figure out how to compile a sketch properly that is not in the examples directory! |
Ok, I resolved the issue, it had nothing to do with this PR. It seems safe to pull. Sorry for the confusion. |
Hm, wouldn't that cause macros to be defined that would indicate the device to be both a Device and a Host, even if it was just either? To me the fact that LUFA doesn't have an "include everything" header indicates that this sort of behaviour would not be supported. Isn't this also what LUFA.c.inc is doing? In any case, I don't think this influences this particular PR, it would be a separate enhancement to discuss. |
the Host specific codes are basically for XMEGA and UC3 MCUs. 8bit AVRs lacks the hardware facilities for Host mode USB. but I agree that would become a separated topic. |
Arduino IDE doesn't compile individual that's why there is a ref. https://github.com/Palatis/Arduino-Lufa/blob/master/examples/LUFA_DualVirtualSerial/LUFA.c |
you forgot to add yourself as a contributor to the "Credits" section in :-P |
Oh that's very interesting, good to know!
Whoops :D |
Resolves #4.
This PR has been tested to compile the DualSerial example on both Arduino IDE 1.8.3 and the VSCode Arduino extension.
To try it out, pull this PR, and use
$ git submodule init; git submodule update
to clone LUFA. After that compilation should just work like it did before.