Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CSGI-2782] Fix import for incident workflow #820

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

cjgajard
Copy link
Contributor

@cjgajard cjgajard commented Feb 16, 2024

Resolves #809

Test case introduced to cover regressions

$ make test TESTARGS='-v -run TestFlattenIncidentWorkflowStepsWithoutSpecifiedSteps'
==> Checking that code complies with gofmt requirements...
go test -i $(go list ./... |grep -v 'vendor') || exit 1
?       github.com/terraform-providers/terraform-provider-pagerduty     [no test files]
echo $(go list ./... |grep -v 'vendor') | \
                xargs -t -n4 go test -v -run TestFlattenIncidentWorkflowStepsWithoutSpecifiedSteps -timeout=30s -parallel=4
go test -v -run TestFlattenIncidentWorkflowStepsWithoutSpecifiedSteps -timeout=30s -parallel=4 github.com/terraform-providers/terraform-provider-pagerduty github.com/terraform-providers/terraform-provider-pagerduty/pagerduty github.com/terraform-providers/terraform-provider-pagerduty/pagerdutyplugin github.com/terraform-providers/terraform-provider-pagerduty/util
?       github.com/terraform-providers/terraform-provider-pagerduty     [no test files]
?       github.com/terraform-providers/terraform-provider-pagerduty/util        [no test files]
=== RUN   TestFlattenIncidentWorkflowStepsWithoutSpecifiedSteps
--- PASS: TestFlattenIncidentWorkflowStepsWithoutSpecifiedSteps (0.00s)
PASS
ok      github.com/terraform-providers/terraform-provider-pagerduty/pagerduty   1.005s
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-pagerduty/pagerdutyplugin     0.597s [no tests to run]

Acceptance Tests result...

$ PAGERDUTY_ACC_INCIDENT_WORKFLOWS=1 make testacc TESTARGS='-run TestAccPagerDutyIncidentWorkflow'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccPagerDutyIncidentWorkflow -timeout 120m
?       github.com/terraform-providers/terraform-provider-pagerduty     [no test files]
?       github.com/terraform-providers/terraform-provider-pagerduty/util        [no test files]
=== RUN   TestAccPagerDutyIncidentWorkflow_import
--- PASS: TestAccPagerDutyIncidentWorkflow_import (13.53s)
=== RUN   TestAccPagerDutyIncidentWorkflowTrigger_import
--- PASS: TestAccPagerDutyIncidentWorkflowTrigger_import (22.20s)
=== RUN   TestAccPagerDutyIncidentWorkflow_Basic
--- PASS: TestAccPagerDutyIncidentWorkflow_Basic (20.49s)
=== RUN   TestAccPagerDutyIncidentWorkflow_Team
--- PASS: TestAccPagerDutyIncidentWorkflow_Team (12.54s)
=== RUN   TestAccPagerDutyIncidentWorkflow_InlineInputs
--- PASS: TestAccPagerDutyIncidentWorkflow_InlineInputs (17.84s)
=== RUN   TestAccPagerDutyIncidentWorkflowTrigger_BadType
--- PASS: TestAccPagerDutyIncidentWorkflowTrigger_BadType (2.72s)
=== RUN   TestAccPagerDutyIncidentWorkflowTrigger_ConditionWithManualType
--- PASS: TestAccPagerDutyIncidentWorkflowTrigger_ConditionWithManualType (2.63s)
=== RUN   TestAccPagerDutyIncidentWorkflowTrigger_ConditionalTypeWithoutCondition
--- PASS: TestAccPagerDutyIncidentWorkflowTrigger_ConditionalTypeWithoutCondition (2.56s)
=== RUN   TestAccPagerDutyIncidentWorkflowTrigger_SubscribedToAllWithInvalidServices
--- PASS: TestAccPagerDutyIncidentWorkflowTrigger_SubscribedToAllWithInvalidServices (2.55s)
=== RUN   TestAccPagerDutyIncidentWorkflowTrigger_BasicManual
--- PASS: TestAccPagerDutyIncidentWorkflowTrigger_BasicManual (22.02s)
=== RUN   TestAccPagerDutyIncidentWorkflowTrigger_BasicConditionalAllServices
--- PASS: TestAccPagerDutyIncidentWorkflowTrigger_BasicConditionalAllServices (19.01s)
=== RUN   TestAccPagerDutyIncidentWorkflowTrigger_ChangeTypeCausesReplace
--- PASS: TestAccPagerDutyIncidentWorkflowTrigger_ChangeTypeCausesReplace (19.38s)
=== RUN   TestAccPagerDutyIncidentWorkflowTrigger_CannotChangeType
--- PASS: TestAccPagerDutyIncidentWorkflowTrigger_CannotChangeType (21.50s)
PASS
ok      github.com/terraform-providers/terraform-provider-pagerduty/pagerduty   179.918s
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-pagerduty/pagerdutyplugin     (cached) [no tests to run]

@cjgajard cjgajard changed the title Fix import for incident workflow (#809) Fix import for incident workflow Feb 16, 2024
@cjgajard cjgajard marked this pull request as ready for review February 16, 2024 15:45
@imjaroiswebdev imjaroiswebdev changed the title Fix import for incident workflow [CSGI-2782] Fix import for incident workflow Feb 16, 2024
Copy link
Contributor

@imjaroiswebdev imjaroiswebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @cjgajard! Thank you for fixing this! 🎉 💪🏽

@imjaroiswebdev imjaroiswebdev merged commit e09b16d into PagerDuty:master Feb 16, 2024
1 check passed
@cjgajard cjgajard deleted the issue-809 branch February 23, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plugin crashes when importing incident workflows
2 participants