Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CSGI-2574] Address: Fail to enable rules in pagerduty_event_orchestration_router #814

Conversation

imjaroiswebdev
Copy link
Contributor

Closes #652

Acceptance tests output and new test case introduced...

$ make testacc TESTARGS="-count=1 -run TestAccPagerDutyEventOrchestration"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -count=1 -run TestAccPagerDutyEventOrchestration -timeout 120m
?       github.com/terraform-providers/terraform-provider-pagerduty     [no test files]
?       github.com/terraform-providers/terraform-provider-pagerduty/util        [no test files]
=== RUN   TestAccPagerDutyEventOrchestrationIntegration_import
--- PASS: TestAccPagerDutyEventOrchestrationIntegration_import (6.78s)
=== RUN   TestAccPagerDutyEventOrchestrationPathGlobal_import
--- PASS: TestAccPagerDutyEventOrchestrationPathGlobal_import (13.93s)
=== RUN   TestAccPagerDutyEventOrchestrationPathRouter_import
--- PASS: TestAccPagerDutyEventOrchestrationPathRouter_import (16.56s)
=== RUN   TestAccPagerDutyEventOrchestrationPathService_import
--- PASS: TestAccPagerDutyEventOrchestrationPathService_import (14.56s)
=== RUN   TestAccPagerDutyEventOrchestrationPathUnrouted_import
--- PASS: TestAccPagerDutyEventOrchestrationPathUnrouted_import (13.49s)
=== RUN   TestAccPagerDutyEventOrchestration_import
--- PASS: TestAccPagerDutyEventOrchestration_import (7.49s)
=== RUN   TestAccPagerDutyEventOrchestrationNameOnly_import
--- PASS: TestAccPagerDutyEventOrchestrationNameOnly_import (4.75s)
=== RUN   TestAccPagerDutyEventOrchestrationIntegration_Basic
--- PASS: TestAccPagerDutyEventOrchestrationIntegration_Basic (21.82s)
=== RUN   TestAccPagerDutyEventOrchestrationPathGlobal_Basic
--- PASS: TestAccPagerDutyEventOrchestrationPathGlobal_Basic (63.05s)
=== RUN   TestAccPagerDutyEventOrchestrationPathRouter_Basic
--- PASS: TestAccPagerDutyEventOrchestrationPathRouter_Basic (54.31s)
=== RUN   TestAccPagerDutyEventOrchestrationPathRouter_EnableRoutingRule # 👈 New test case introduced
--- PASS: TestAccPagerDutyEventOrchestrationPathRouter_EnableRoutingRule (19.79s)
=== RUN   TestAccPagerDutyEventOrchestrationPathService_Basic
--- PASS: TestAccPagerDutyEventOrchestrationPathService_Basic (115.73s)
=== RUN   TestAccPagerDutyEventOrchestrationPathUnrouted_Basic
--- PASS: TestAccPagerDutyEventOrchestrationPathUnrouted_Basic (46.91s)
=== RUN   TestAccPagerDutyEventOrchestration_Basic
--- PASS: TestAccPagerDutyEventOrchestration_Basic (17.06s)
PASS
ok      github.com/terraform-providers/terraform-provider-pagerduty/pagerduty   417.516s
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-pagerduty/pagerdutyplugin     0.814s [no tests to run]

$ make testacc TESTARGS="-count=1 -run TestAccDataSourcePagerDutyEventOrchestration"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -count=1 -run TestAccDataSourcePagerDutyEventOrchestration -timeout 120m
?       github.com/terraform-providers/terraform-provider-pagerduty     [no test files]
?       github.com/terraform-providers/terraform-provider-pagerduty/util        [no test files]
=== RUN   TestAccDataSourcePagerDutyEventOrchestrationIntegration_Basic
--- PASS: TestAccDataSourcePagerDutyEventOrchestrationIntegration_Basic (276.76s)
=== RUN   TestAccDataSourcePagerDutyEventOrchestration_Basic
--- PASS: TestAccDataSourcePagerDutyEventOrchestration_Basic (5.99s)
=== RUN   TestAccDataSourcePagerDutyEventOrchestrations_Basic
--- PASS: TestAccDataSourcePagerDutyEventOrchestrations_Basic (22.59s)
PASS
ok      github.com/terraform-providers/terraform-provider-pagerduty/pagerduty   306.004s
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-pagerduty/pagerdutyplugin     0.981s [no tests to run]

Depends on heimweh/go-pagerduty#148

Copy link
Contributor

@alenapan alenapan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thank you for fixing this! 🎉

go.mod Outdated Show resolved Hide resolved
@imjaroiswebdev imjaroiswebdev marked this pull request as ready for review February 6, 2024 15:22
@imjaroiswebdev imjaroiswebdev merged commit 4d2a0b7 into PagerDuty:master Feb 6, 2024
1 check passed
@imjaroiswebdev imjaroiswebdev deleted the issue-652-fail-enabling-eo-routes branch February 6, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail to enable rules in pagerduty_event_orchestration_router
2 participants