Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CSGI-2017 ] Update pagerduty_user_contact_method address validation logic #792

Conversation

imjaroiswebdev
Copy link
Contributor

@imjaroiswebdev imjaroiswebdev commented Dec 20, 2023

Update format validation for pagerduty_user_contact_method.address based on PagerDuty officially supported phone number formatting rules.

Introduces the following new test cases...

$ make testacc TESTARGS="-count=1 -run TestAccPagerDutyUserContactMethodPhone_FormatValidation"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -count=1 -run TestAccPagerDutyUserContactMethodPhone_FormatValidation -timeout 120m
?       github.com/terraform-providers/terraform-provider-pagerduty     [no test files]
=== RUN   TestAccPagerDutyUserContactMethodPhone_FormatValidation
--- PASS: TestAccPagerDutyUserContactMethodPhone_FormatValidation (1.72s)
PASS
ok      github.com/terraform-providers/terraform-provider-pagerduty/pagerduty   2.428s

@imjaroiswebdev imjaroiswebdev force-pushed the support-new-phone-number-format branch from 9afb405 to 967370d Compare December 20, 2023 14:33
@imjaroiswebdev imjaroiswebdev merged commit a744105 into PagerDuty:master Dec 20, 2023
1 check passed
@imjaroiswebdev imjaroiswebdev deleted the support-new-phone-number-format branch December 20, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants