Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CSGI-2303] Hotfix - Alert grouping parameters input validation broken #779

Conversation

imjaroiswebdev
Copy link
Contributor

Closes #778

Test cases extended...

$ make testacc TESTARGS="-run TestAccPagerDutyService_AlertContentGrouping"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccPagerDutyService_AlertContentGrouping -timeout 120m
?       github.com/terraform-providers/terraform-provider-pagerduty     [no test files]
=== RUN   TestAccPagerDutyService_AlertContentGrouping # 👈 Test case extended to cover regression
--- PASS: TestAccPagerDutyService_AlertContentGrouping (66.24s)
=== RUN   TestAccPagerDutyService_AlertContentGroupingIntelligentTimeWindow
--- PASS: TestAccPagerDutyService_AlertContentGroupingIntelligentTimeWindow (19.25s)
PASS
ok      github.com/terraform-providers/terraform-provider-pagerduty/pagerduty   86.107s
$ make testacc TESTARGS="-run TestAccPagerDutyService_FormatValidation"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccPagerDutyService_FormatValidation -timeout 120m
?       github.com/terraform-providers/terraform-provider-pagerduty     [no test files]
=== RUN   TestAccPagerDutyService_FormatValidation # 👈 Test case extended to cover regression
--- PASS: TestAccPagerDutyService_FormatValidation (34.79s)
PASS
ok      github.com/terraform-providers/terraform-provider-pagerduty/pagerduty   35.488s

@imjaroiswebdev
Copy link
Contributor Author

Proceeding to merge in order to promptly patch #778

@imjaroiswebdev imjaroiswebdev merged commit 3462f33 into PagerDuty:master Dec 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Content based alert grouping is broken
1 participant