Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pagerduty_team_members data source #717

Merged
merged 4 commits into from
Dec 21, 2023
Merged

add pagerduty_team_members data source #717

merged 4 commits into from
Dec 21, 2023

Conversation

mdb
Copy link
Contributor

@mdb mdb commented Jul 29, 2023

This addresses issue #716 and adds a pagerduty_team_members data source for fetching the team members associated with a team, including the team role associated with each.

Example usage:

data "pagerduty_team_members" "foo" {
  team_id = resource.pagerduty_team.foo.id
}

New test cases introduced...

$ make testacc TESTARGS="-count=1 -run TestAccDataSourcePagerDutyTeamMembers"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -count=1 -run TestAccDataSourcePagerDutyTeamMembers -timeout 120m
?       github.com/terraform-providers/terraform-provider-pagerduty     [no test files]
=== RUN   TestAccDataSourcePagerDutyTeamMembers_Basic
--- PASS: TestAccDataSourcePagerDutyTeamMembers_Basic (13.14s)
PASS
ok      github.com/terraform-providers/terraform-provider-pagerduty/pagerduty   13.852s

Closes #716

@bharling
Copy link

bharling commented Aug 1, 2023

👍

mdb and others added 4 commits December 21, 2023 19:06
This addresses issue #716 and adds a `pagerduty_team_members` data source for
fetching the team members associated with a team, including the team role
associated with each.

Example usage:

```hcl
data "pagerduty_team_members" "foo" {
  team_id = resource.pagerduty_team.foo.id
}
```

Signed-off-by: Mike Ball <mikedball@gmail.com>
@imjaroiswebdev imjaroiswebdev self-requested a review December 21, 2023 22:20
Copy link
Contributor

@imjaroiswebdev imjaroiswebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @mdb! I only had to chime in to do some tweaks here and there, however the big chunk of the work was very well done by you. Thank you so much for your contribution 💪🏽 🎉 🕺🏽

@imjaroiswebdev imjaroiswebdev merged commit 789f380 into PagerDuty:master Dec 21, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: create pagerduty_team_members data source for reading team members' team roles
3 participants