Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address #655 Tags are not cleaned up from State after removed externally #670

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Address #655 Tags are not cleaned up from State after removed externally #670

merged 1 commit into from
Apr 5, 2023

Conversation

imjaroiswebdev
Copy link
Contributor

Closes #655

Test cases extended...

$ make testacc TESTARGS="-run TestAccPagerDutyTag_Basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccPagerDutyTag_Basic -timeout 120m
?       github.com/terraform-providers/terraform-provider-pagerduty     [no test files]
=== RUN   TestAccPagerDutyTag_Basic
--- PASS: TestAccPagerDutyTag_Basic (5.39s)
PASS
ok      github.com/terraform-providers/terraform-provider-pagerduty/pagerduty   5.864s

@imjaroiswebdev imjaroiswebdev force-pushed the handle-tags-externally-removed branch from 93f8e0d to 9ab0173 Compare April 5, 2023 22:13
@imjaroiswebdev imjaroiswebdev marked this pull request as ready for review April 5, 2023 22:15
@imjaroiswebdev imjaroiswebdev merged commit 7363d9a into PagerDuty:master Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tags are not cleaned up from the terraform state after being deleted externally
1 participant
@imjaroiswebdev