Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RDC-1062 add node filter to process automation job #647

Merged
merged 3 commits into from
Mar 10, 2023
Merged

RDC-1062 add node filter to process automation job #647

merged 3 commits into from
Mar 10, 2023

Conversation

juliannagreen1
Copy link
Contributor

@juliannagreen1 juliannagreen1 commented Mar 7, 2023 •
edited
Loading

Adds node filtering for automation_action resources.

Ex.

resource "pagerduty_automation_actions_action" "pa_action_example" {
  name = "PA Action created/updated via TF"
  description = "Description of the PA Action created via TF"
  action_type = "process_automation"
  action_data_reference {
    process_automation_job_id = "12345"
    process_automation_node_filter = "tags: production"
  }
}

Depends on heimweh/go-pagerduty#126

@juliannagreen1 juliannagreen1 marked this pull request as ready for review March 8, 2023 21:17
mrdubr
mrdubr approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@mrdubr mrdubr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imjaroiswebdev imjaroiswebdev self-requested a review March 9, 2023 22:20
imjaroiswebdev
imjaroiswebdev requested changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@imjaroiswebdev imjaroiswebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since heimweh/go-pagerduty#126 was merged, could you please update the dependencies and vendor modules? Additionally please rebase this branch on top of master for a clean merge. Thank you @juliannagreen1 ✌🏽 😄

imjaroiswebdev
imjaroiswebdev approved these changes Mar 10, 2023
View reviewed changes
Copy link
Contributor

@imjaroiswebdev imjaroiswebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @juliannagreen1 this looks awesome! Thank you! 🎉 😎

@imjaroiswebdev imjaroiswebdev merged commit f3dc74a into PagerDuty:master Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imjaroiswebdev imjaroiswebdev imjaroiswebdev approved these changes

@mrdubr mrdubr mrdubr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juliannagreen1 @mrdubr @imjaroiswebdev