Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Automation Actions' Action association to a Service #608

Merged
merged 4 commits into from
Jan 9, 2023
Merged

Add support for Automation Actions' Action association to a Service #608

merged 4 commits into from
Jan 9, 2023

Conversation

imjaroiswebdev
Copy link
Contributor

Add support for resource pagerduty_automation_actions_action_service_association

New tests cases introduced...

$ make testacc TESTARGS="-run TestAccPagerDutyAutomationActionsActionServiceAssociation"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccPagerDutyAutomationActionsActionServiceAssociation -timeout 120m
?       github.com/terraform-providers/terraform-provider-pagerduty     [no test files]
=== RUN   TestAccPagerDutyAutomationActionsActionServiceAssociation_import
--- PASS: TestAccPagerDutyAutomationActionsActionServiceAssociation_import (15.37s)
=== RUN   TestAccPagerDutyAutomationActionsActionServiceAssociation_Basic
--- PASS: TestAccPagerDutyAutomationActionsActionServiceAssociation_Basic (14.10s)
PASS
ok      github.com/terraform-providers/terraform-provider-pagerduty/pagerduty   30.289s

Depends on: heimweh/go-pagerduty#115

mrdubr
mrdubr suggested changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@mrdubr mrdubr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typos and nits

website/docs/r/automation_actions_action_service_association.html.markdown Outdated Show resolved Hide resolved
website/docs/r/automation_actions_action_service_association.html.markdown Outdated Show resolved Hide resolved
@imjaroiswebdev imjaroiswebdev marked this pull request as ready for review January 6, 2023 16:48
@imjaroiswebdev imjaroiswebdev requested review from mrdubr and stmcallister and removed request for mrdubr January 6, 2023 16:49
@imjaroiswebdev imjaroiswebdev force-pushed the a2actionAssociationWithService branch from 0c70004 to f7ad1ee Compare January 9, 2023 16:56
@imjaroiswebdev imjaroiswebdev requested a review from mrdubr January 9, 2023 16:57
@imjaroiswebdev imjaroiswebdev merged commit da7fa3b into PagerDuty:master Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrdubr mrdubr mrdubr approved these changes

@stmcallister stmcallister Awaiting requested review from stmcallister

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imjaroiswebdev @mrdubr