Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for pagerduty_automation_actions_action #599

Merged
merged 8 commits into from
Dec 16, 2022
Merged

Add support for pagerduty_automation_actions_action #599

merged 8 commits into from
Dec 16, 2022

Conversation

mrdubr
Copy link
Contributor

@mrdubr mrdubr commented Dec 14, 2022 •
edited
Loading

Add support for pagerduty_automation_actions_action

New test cases introduced:

$ make testacc TESTARGS="-run TestAccPagerDutyAutomationActionsAction*"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccPagerDutyAutomationActionsAction* -timeout 120m
?   	github.com/terraform-providers/terraform-provider-pagerduty	[no test files]
=== RUN   TestAccPagerDutyAutomationActionsAction_import
--- PASS: TestAccPagerDutyAutomationActionsAction_import (11.62s)
=== RUN   TestAccPagerDutyAutomationActionsActionTypeProcessAutomation_Basic
--- PASS: TestAccPagerDutyAutomationActionsActionTypeProcessAutomation_Basic (7.94s)
=== RUN   TestAccPagerDutyAutomationActionsActionTypeScript_Basic
--- PASS: TestAccPagerDutyAutomationActionsActionTypeScript_Basic (6.38s)
PASS
ok  	github.com/terraform-providers/terraform-provider-pagerduty/pagerduty	26.562s

Depends on: heimweh/go-pagerduty#106

@mrdubr mrdubr marked this pull request as ready for review December 14, 2022 22:15
@mrdubr mrdubr changed the title Support a2 actions Add support for pagerduty_automation_actions_action Dec 14, 2022
@imjaroiswebdev imjaroiswebdev self-requested a review December 15, 2022 13:41
imjaroiswebdev
imjaroiswebdev reviewed Dec 15, 2022
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@mrdubr
doc fixes
6102b40
@mrdubr
update to use heimweh/go-pagerduty
cd53b73 
go mod edit -dropreplace github.com/heimweh/go-pagerduty
go get github.com/heimweh/go-pagerduty/pagerduty && go mod tidy && go mod vendor
@mrdubr mrdubr requested review from imjaroiswebdev and removed request for stmcallister December 15, 2022 15:48
@mrdubr
Copy link
Contributor Author

mrdubr commented Dec 15, 2022

Hey @stmcallister , not sure why the system has removed the request for your review. I would appreciate it if you get a chance. :ty

imjaroiswebdev
imjaroiswebdev approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@imjaroiswebdev imjaroiswebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! thank you for adding the updates to solve the comments @mrdubr this is a great implementation. Users will love to use Automation Actions 💪🏽

stmcallister
stmcallister approved these changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@stmcallister stmcallister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🌮 🎉 Looks awesome!!

@imjaroiswebdev imjaroiswebdev merged commit a4d824e into PagerDuty:master Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imjaroiswebdev imjaroiswebdev imjaroiswebdev approved these changes

@stmcallister stmcallister stmcallister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrdubr @stmcallister @imjaroiswebdev