Test rule removal rather than update for Escalation Policy Dependent Schedule #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drastawi
changed the title
drastawi
changed the title
|
@imjaroiswebdev PTAL |
imjaroiswebdev
force-pushed
the
patch-2
branch
from
031004d to
dbb8759
Compare
imjaroiswebdev
approved these changes
Sep 9, 2022
There was a problem hiding this comment.
Hey @drastawi! One more time thank you for contributing with this patch that solves this missing case. I only rebased your commits to the current master state and refactor your patch just for code readability purpose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like there is a case missing in #561
The code should work for rule update as well as rule removal.