-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #532
Update dependencies #532
Conversation
The new terraform SDK check comes from hashicorp/terraform-plugin-sdk#920 which was released in https://github.com/hashicorp/terraform-plugin-sdk/blob/v2.13.0/CHANGELOG.md#2130-march-31-2022 |
As I suggested in #525 (comment), |
@@ -1,13 +1,68 @@ | |||
module github.com/terraform-providers/terraform-provider-pagerduty | |||
|
|||
go 1.16 | |||
go 1.18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switching to go 1.18 is required by newer hcl v2 version:
Without this:
make testacc TEST=./pagerduty/ TESTARGS='-run=TestAccPagerDutyService_AlertContentGrouping'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./pagerduty/ -v -run=TestAccPagerDutyService_AlertContentGrouping -timeout 120m
# github.com/hashicorp/hcl/v2
vendor/github.com/hashicorp/hcl/v2/diagnostic_typeparams.go:22:22: type parameter requires go1.18 or later (-lang was set to go1.16; check go.mod)
vendor/github.com/hashicorp/hcl/v2/diagnostic_typeparams.go:22:24: undeclared name: any (requires version go1.18 or later)
FAIL github.com/terraform-providers/terraform-provider-pagerduty/pagerduty [build failed]
FAIL
make: *** [GNUmakefile:17: testacc] Error 2
See hashicorp/hcl@c3b6715#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6R3
and hashicorp/hcl@88ecd13#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6R3
I would like to see this PR finished and merged. Such an important piece of the infrastructure cannot be left with old dependencies. (rf: #732) |
This PR updates all dependencies, most notably terraform SDK which reveals an error in recently added changes.
Note: this PR is just the result from running
go get -u ./... && go mod tidy && go mod vendor