resource/pagerduty_schedule: suppress spurious start diff #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: PagerDuty#200 When both schedule layer start time (the old one read from PagerDuty API, and the new one read from configuration files) are in the past, there is no need to show Diff as the acutual start time will be updated by PagerDuty API to current time. Otherwise, users will have to sync the configuration files from time to time, when they make irrelevant changes to their schedules (e.g., adding a user) or even no changes at all.
drastawi
approved these changes
Jun 8, 2021
There was a problem hiding this comment.
This is great @Padorax. Hopefully it can get merged soon. cc @stmcallister
stmcallister
approved these changes
Jun 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #200
When both schedule layer start time (the old one read from PagerDuty API, and the new one read
from configuration files) are in the past, there is no need to show Diff as the acutual start
time will be updated by PagerDuty API to current time.
Otherwise, users will have to sync the configuration files from time to time, when they make
irrelevant changes to their schedules (e.g., adding a user) or even no changes at all.