Allowing "Removal" of Schedule Layers #257
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for the "removal" of schedule layers. Removal is in quotes because the PagerDuty API doesn't allow for deleting of schedule layers--you can only end them. That is what this PR does is set the
end
value for a schedule layer when you remove the layer from your tf config. Also, added tests for setting theend
for a schedule layer, as well as updated theTestAccPagerDutySchedule_Multi
test to include updating a schedule by removing a layer.Finally, removed the
ForceNew
on schedule layers. Now changes to schedule layers will not force a new creation of a schedule object. Which addresses #43