[MODULES] Switch to Go Modules #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
appilon
force-pushed
the
go-modules-2019-03-01
branch
from
5c11f05 to
c88a59a
Compare
|
@appilon Do you mind rebasing this so we can run tests with the patch from https://github.com/terraform-providers/terraform-provider-pagerduty/pull/116 included? I think there is still some low hanging fruit - tests we can fix and I'd like to look into these. The existing SDK which is vendored to this provider is unfortunately so old that it doesn't have support for granular logging per test, so debugging these tests on your branch is much easier. 😑 Thanks. |
appilon
force-pushed
the
go-modules-2019-03-01
branch
from
c88a59a to
e44c112
Compare
|
@radeksimko rebased! |
appilon
force-pushed
the
go-modules-2019-03-01
branch
2 times, most recently
from
5d4bf4e to
12a665f
Compare
provider: Run go fix provider: Run go fmt provider: Encode go version 1.11.5 to .go-version file
run go mod tidy remove govendor from makefile and travis config set appropriate env vars for go modules
Updated via: go get github.com/hashicorp/terraform@sdk-v0.11-with-go-modules and go mod tidy
appilon
force-pushed
the
go-modules-2019-03-01
branch
from
12a665f to
56cfeb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #113