Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add try/except around slack channel updates to handle keyerror when t… #16

Merged
merged 3 commits into from
Oct 22, 2019
Merged

add try/except around slack channel updates to handle keyerror when t… #16

merged 3 commits into from
Oct 22, 2019

Conversation

jessica-ritter
Copy link
Contributor

…he bot is not allowed or channel is archived

jolexa
jolexa approved these changes Oct 21, 2019
View reviewed changes
Copy link
Member

@jolexa jolexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I understand, this will add logs to a known failure case instead of throwing an exception. That is a nice improvement.

@jessica-ritter jessica-ritter merged commit ed37edf into master Oct 22, 2019
@margueritepd margueritepd deleted the error-handling-channel-fix branch April 20, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jolexa jolexa jolexa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jessica-ritter @jolexa