fix: Support the From header when snoozing an incident

[adamdecaf]

The API docs list From as a required header.

https://developer.pagerduty.com/api-reference/fc871396fb23f-snooze-an-incident#request-headers

[adamdecaf]

This is a breaking change but the snooze calls don't work currently, so they're already broken.

[adamdecaf]

cc @ChuckCrawford @imjaroiswebdev

[ChezCrawford]

If you don't mind addressing the tiny comments I would be happy to get this merged.

[adamdecaf]

@ChezCrawford thanks - should be g2g now

[ChezCrawford]

Ahhh. As I am coming out of my holiday-vacation-fog I am realizing that this is actually a breaking change for some users. The From header is only required when using an Account API Key or an App OAuth Token. Clients authenticating with User API Keys are currently able to use this function without issue.

If we are going to make a breaking change here I am tempted to ask that we do this the right way by adding a SnoozeIncidentOptions struct with From and Duration fields. Let me brood on this until I am back at work.

[adamdecaf]

I can make that change to use a struct. Yes, it's breaking but for me Snooze wasn't even working without this.

[ChezCrawford]

Yes, it's breaking but for me Snooze wasn't even working without this.

You are likely using one of the two types of tokens I mentioned above. I did verify that it works correctly with User API Keys right now.

I can make that change to use a struct.

I think that is the best move here. If we are going to make a breaking change let's change it to the "correct" thing that will work properly for everyone.

[adamdecaf]

Updated the PR. Thanks for helping get this merged.

[ChuckCrawford]

Note that this PR makes a breaking change in order to add support for the snooze incident API with Account API Keys and App Tokens.