Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow service timeouts to be disabled #53

Merged
merged 1 commit into from
Jan 28, 2017
Merged

Allow service timeouts to be disabled #53

merged 1 commit into from
Jan 28, 2017

Conversation

heimweh
Copy link
Contributor

@heimweh heimweh commented Nov 17, 2016

This should allow both AutoResolveTimeout and AcknowledgementTimeout to be disabled.

However this does break the ability to just use the API defaults (which is enabled).
Maybe instead of this, we could have an enabled/disabled bool flag?

@heimweh heimweh changed the title Allow timeouts to be disabled Allow service timeouts to be disabled Nov 17, 2016
@jtsaito jtsaito mentioned this pull request Jan 27, 2017
Closed
@heimweh
Copy link
Contributor Author

heimweh commented Jan 27, 2017

Thanks @jtsaito for looking into this, almost forgot about this one.
Would be awesome to get this merged.

@ranjib any chance you could take a look at this one? :) many thanks

brhou
brhou approved these changes Jan 27, 2017
View reviewed changes
Copy link

@brhou brhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the language constraints here, I agree that this is the better of the two options.

Deconstrained
Deconstrained reviewed Jan 28, 2017
View reviewed changes
Copy link
Contributor

@Deconstrained Deconstrained left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I too have reviewed and have tested this, and it looks good. Thank you!

@Deconstrained Deconstrained merged commit fad777c into PagerDuty:master Jan 28, 2017
@jtsaito
Copy link

jtsaito commented Jan 28, 2017 •
edited
Loading

@heimweh @brhou @Deconstrained Thank you very much for looking into this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Deconstrained Deconstrained Deconstrained left review comments

@brhou brhou brhou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@heimweh @jtsaito @Deconstrained @brhou