Add mechanism to list more than 100 incidents #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default we can reach only 100 elements from a given range, if we have more than 100 elements between `Since` and `Until`, we need to use an offeset to get the 101st element and so on.
|
I will implement it for v1.4.2. If you think is good for the project, I will reopen it. |
theckman
requested changes
Mar 13, 2022
| @@ -183,6 +188,37 @@ func (c *Client) ListIncidentsWithContext(ctx context.Context, o ListIncidentsOp | |||
| return &result, nil | |||
| } | |||
|
|
|||
| // ListIncidentsPaginated lists existing services processing paginated responses | |||
| func (c *Client) ListIncidentsPaginatedWithContext(ctx context.Context, o ListIncidentsOptions) ([]Incident, error) { | |||
There was a problem hiding this comment.
I don't think this method signature aligns with future plans of the project. The WithContext should be removed from the name, as this is a new method and we have no reason to support a non-context APIs for new things. Also, it should accept an include function that allows filtering of unwanted items.
| @@ -163,6 +164,10 @@ func (c *Client) ListIncidents(o ListIncidentsOptions) (*ListIncidentsResponse, | |||
| return c.ListIncidentsWithContext(context.Background(), o) | |||
| } | |||
|
|
|||
| func (c *Client) ListIncidentsPaginated(o ListIncidentsOptions) ([]Incident, error) { | |||
There was a problem hiding this comment.
This method should be removed, as we don't want to introduce new methods that don't accept a context.Contex.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default we can reach only 100 elements from a given range, if we have more than 100 elements
between
SinceandUntil, we need to use an offeset to get the 101st element and so on.