Add support for escalation_policy.on_call_handoff_notifications field #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theckman
requested changes
Nov 25, 2021
escalation_policy_test.go
Outdated
| t.Fatal(err) | ||
| } | ||
| testEqual(t, want, res) | ||
|
|
There was a problem hiding this comment.
Smallest of nits, could you clean up this empty line?
zonorti
force-pushed
the
on_call_handoff_notifications
branch
from
5e0cdd1 to
25b469f
Compare
theckman
approved these changes
Nov 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #395
I added a test, just in case, but it basically checks JSON Unmarshal.
As CLI uses JSON files as input no changes on that side are needed.
Not sure if any docs need an update.