Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix query params on tags #329

Merged
merged 1 commit into from
May 13, 2021
Merged

Fix query params on tags #329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tag.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@ func getTagList(ctx context.Context, c *Client, entityType, entityID string, o L
}

// Make call to get all pages associated with the base endpoint.
if err := c.pagedGet(ctx, path+queryParms.Encode(), responseHandler); err != nil {
if err := c.pagedGet(ctx, path+"?"+queryParms.Encode(), responseHandler); err != nil {
return nil, err
}

Expand Down
2 changes: 2 additions & 0 deletions tag_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,15 @@ func TestTag_List(t *testing.T) {

mux.HandleFunc("/tags/", func(w http.ResponseWriter, r *http.Request) {
testMethod(t, r, "GET")
testEqual(t, r.URL.Query()["query"], []string{"MyTag"})
_, _ = w.Write([]byte(`{"tags": [{"id": "1","label":"MyTag"}]}`))
})

listObj := APIListObject{Limit: 0, Offset: 0, More: false, Total: 0}
client := &Client{apiEndpoint: server.URL, authToken: "foo", HTTPClient: defaultHTTPClient}
opts := ListTagOptions{
APIListObject: listObj,
Query: "MyTag",
}
res, err := client.ListTags(opts)
if err != nil {
Expand Down