Update business_service.go to accept a context.Context #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theckman
commented
Feb 27, 2021
| } | ||
|
|
||
| // CreateBusinessServiceWithContext creates a new business service. | ||
| func (c *Client) CreateBusinessServiceWithContext(ctx context.Context, b *BusinessService) (*BusinessService, error) { |
There was a problem hiding this comment.
@stmcallister similar to #293, I'm curious of your thoughts around removing the *http.Response from these methods.
There was a problem hiding this comment.
As mentioned in #293, as long as we can get the same information from somewhere--in this case, from the APIError object--we should be okay with this change.
theckman
commented
Feb 27, 2021
|
|
||
| // ListBusinessServicesPaginated lists existing business services, automatically | ||
| // handling pagination and returning the full collection. | ||
| func (c *Client) ListBusinessServicesPaginated(ctx context.Context, o ListBusinessServiceOptions) ([]*BusinessService, error) { |
There was a problem hiding this comment.
This takes naming inspiration from #295.
This also updates the new methods to not return the `*http.Response`, as it doesn't seem needed. Updates #267
theckman
force-pushed
the
ctx_business_service
branch
from
d6a955c to
a697638
Compare
This was referenced Feb 27, 2021
stmcallister
approved these changes
Mar 15, 2021
|
|
||
| // ListBusinessServicesPaginated lists existing business services, automatically | ||
| // handling pagination and returning the full collection. | ||
| func (c *Client) ListBusinessServicesPaginated(ctx context.Context, o ListBusinessServiceOptions) ([]*BusinessService, error) { |
| } | ||
|
|
||
| // CreateBusinessServiceWithContext creates a new business service. | ||
| func (c *Client) CreateBusinessServiceWithContext(ctx context.Context, b *BusinessService) (*BusinessService, error) { |
There was a problem hiding this comment.
As mentioned in #293, as long as we can get the same information from somewhere--in this case, from the APIError object--we should be okay with this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also updates the new methods to not return the
*http.Response, as itdoesn't seem needed.
Updates #267