Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return nil instead of resp on error #278

Merged
merged 2 commits into from
Mar 7, 2021
+1 −1
Merged

return nil instead of resp on error #278

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f41ecbb
return nil instead of resp on error
blockpane Feb 20, 2021
baebca9
gofmt file
blockpane Mar 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion event.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ func CreateEventWithHTTPClient(e Event, client HTTPClient) (*EventResponse, erro
req.Header.Set("Content-Type", "application/json")
resp, err := client.Do(req)
if err != nil {
return &EventResponse{HttpStatus: resp.StatusCode}, err
return nil, fmt.Errorf("failed to action request: %w", err)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be able to go fmt this file? Just noticed the whitespace before nil when getting ready to merge.

}
defer resp.Body.Close()
if resp.StatusCode != http.StatusOK {
Expand Down