business_service: clean b.ID before calling UPDATE #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PUT `/business_services/{id}` doesn't accept `ID` in the body:
https://developer.pagerduty.com/api-reference/reference/REST/openapiv3.json/paths/~1business_services~1%7Bid%7D/put
However, specifying it for the `go-pagerduty` to work is mandatory.
Thus, it is impossible to use this method ATM without this fix. Let's
clear `b.ID` before calling `PUT` and store it in a separate variable.
Testing: my code calling this method works again with these changes.
Otherwise, the following error is spotted:
```
Failed call API endpoint. HTTP response code: 400. Error: \u0026{400 Invalid input [The field id is invalid.]}
```
|
@stmcallister could you please look into this? |
stmcallister
approved these changes
Dec 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PUT
/business_services/{id}doesn't acceptIDin the body:https://developer.pagerduty.com/api-reference/reference/REST/openapiv3.json/paths/~1business_services~1%7Bid%7D/put
However, specifying it for the
go-pagerdutyto work is mandatory.Thus, it is impossible to use this method ATM without this fix. Let's
clear
b.IDbefore callingPUTand store it in a separate variable.Testing: my code calling this method works again with these changes.
Otherwise, the following error is spotted:
I have added a small test case to the suite. LMK if this looks good.