Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing panic inCreateEventWithHTTPClient #224

Closed
wants to merge 2 commits into from
Closed

fixing panic inCreateEventWithHTTPClient #224

wants to merge 2 commits into from

Conversation

stmcallister
Copy link
Contributor

This is in response to issue #211 .

theckman
theckman requested changes May 15, 2020
View reviewed changes
Copy link
Collaborator

@theckman theckman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If err != nil, resp is going to be nil here. There's no use for this check, we should just not use resp until we confirmed there was no error.

@stmcallister stmcallister requested a review from theckman June 4, 2020 16:13
@stmcallister stmcallister mentioned this pull request Dec 11, 2020
Closed
@theckman
Copy link
Collaborator

Closing in favor of #278

@theckman theckman closed this Feb 20, 2021
@theckman theckman deleted the event-panic branch May 16, 2021 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dobs dobs dobs approved these changes

@theckman theckman Awaiting requested review from theckman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stmcallister @theckman @dobs