Change makefiles and readme

[dineshba]

Tasks:

1. Introduce go mod
2. Update Makefile targets

[dineshba]

Fixes this issue also #160

[stmcallister]

Just merged another PR that introduced modules. However, I really like what you're doing with the config and Makefiles. If you change the PR to only be the updates to config and makefile, that would be an awesome addition to the project.

One question about the Makefile. Do you have a strong opinion about setting GO111MODULE=on? We would prefer that it's set to GO111MODULE=auto. Thanks!

[dineshba]

Hi @stmcallister Made the changes to the PR. I am okay with GO111MODULE being auto.

[stmcallister]

Thanks, @dineshba! Also, any strong objections to adding the following lines to .gitignore?

vendor/
pd

[dineshba]

@stmcallister Added pd to gitignore.

Can we check in vendor folder to git ? Advantage: Builds will be very fast in CI(as vendor is already present with code). Whats your opinion on this ?

[stmcallister]

@dineshba We discussed this internally, and checking the vendor directory into the repo has pluses and negatives. The build speed you mentioned would be nice, but the policing of dependencies would be more tedious. Especially when developers can get the same benefit by running go mod vendor. So, we would rather not check the vendor directory into the repo, but instead either have devs run go mod vendor or include that in the makefile.

[dineshba]

@stmcallister I agree with you. Added vendor/ to .gitignore. As you suggested, developers can still use go mod vendor and build using vendor directory. So i didn't modify Makefile