Create Incident, List Priorities, and headers in POST method support #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
June 6, 2018 11:10
ldelossa
force-pushed
the
incident-priorities-support
branch
from
a5a2cdb to
51d7663
Compare
ldelossa
changed the title
|
I think the method name should be CreateIncident not CreateIncidents since it creates a singular incident The naming of the type to pass into the CreateIncident should be CreateIncidentOptions to match other method signatures |
|
Since CreateIncidentResponse isn't returned anywhere (just used to unmarshal the response inside CreateIncident(s) ), should it be un-exported? (I struggled with same thing on my PR) |
|
@wdhnl agree to both your comments, will update. |
|
Will you have time to update this? |
|
@wdhnl dunzo. sorry about that got side tracked. |
|
@mattstratton can you evaluate this PR? |
|
Hey Bill I just realized I missed one of the recommendations. Will fix
tonight or first thing tomorrow
…On Wed, Jun 20, 2018 at 5:55 PM Bill Hathaway ***@***.***> wrote:
@mattstratton <https://github.com/mattstratton> can you evaluate this PR?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#122 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFYalp8UbDo7Tw5PtxnntBguPsdgbxMxks5t-sTKgaJpZM4UddPL>
.
|
|
@wdhnl renamed CreateIncidentValue to CreateIncidentOptions like suggested. |
|
awesome, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitting this PR which adds support for POSTing (creating) an incident along with GETing (listing) priorities in the new priorities feature. Willing to change around any struct naming or json construction logic at request.
Methods added:
client.CreateIncidents
client.ListPriorities
PR also plumbed header support into POST method on the client.