Added From parameter to createNote function #108
Conversation
|
When you want to create a note on an incident. The API Guide specifies that the user's email address should be passed as a parameter in the header using the "From" field. See https://v2.developer.pagerduty.com/v2/page/api-reference#!/Incidents/post_incidents_id_notes . However this is missing in the library, so I have updated the library to enable this. |
|
Hi, pls could you review and merge @aantix @raganwald @rduffield @taavi @jolexa @mimato thanks |
An easier way to request a review:
:-) |
|
@raganwald I tried that but it doesn't give me the option to request a reviewer. I think that option is access protected and only visible to your team
|
|
@nnoromuche Can you rebase and update this PR, since there's now a conflict? I'll review it then. Sorry for the delay! |
This branch incorporates a bunch of old un-merged PRs from upstream, specifically: - PagerDuty#72 - PagerDuty#73 - PagerDuty#74 - PagerDuty#75 - PagerDuty#78 - PagerDuty#91 - PagerDuty#93 - PagerDuty#97 - PagerDuty#104 - PagerDuty#106 - PagerDuty#108 - PagerDuty#113 - PagerDuty#114 - PagerDuty#126 - PagerDuty#127 - PagerDuty#130 - PagerDuty#132 - PagerDuty#137 - PagerDuty#138 - PagerDuty#140 - PagerDuty#143 It doesn't attempt to merge, due to potential complexity: - PagerDuty#48 - PagerDuty#99 - PagerDuty#134 And skips the following as it was picked up as part of pulling in the above merged PRs: - PagerDuty#133 Will have subsequent PRs for cleanup, specifically: - Reducing duplicate code. - Standardizing response and error handling. Followed by more janitorial and refactor-oriented changes.
#107