Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ManageIncidents - support set resolution #243

Closed
hagaishapira opened this issue Sep 21, 2020 · 2 comments · Fixed by #313
Closed

ManageIncidents - support set resolution #243

hagaishapira opened this issue Sep 21, 2020 · 2 comments · Fixed by #313
Labels
help wanted open question there is an open question on the issue / PR
Milestone

Comments

@hagaishapira
Copy link

In case of incident resolution (status is resolved) the API allows to set a resolution string.
As far as I can see, this is currently not supported.

@hagaishapira hagaishapira changed the title ManageIncidents - support to set resolution ManageIncidents - support set resolution Sep 21, 2020
@theckman
Copy link
Collaborator

@hagaishapira would you be willing / able to get a PR raised to add that field to this type:

go-pagerduty/incident.go

Lines 155 to 162 in 69ade4b

// ManageIncidentsOptions is the structure used when PUTing updates to incidents to the ManageIncidents func
type ManageIncidentsOptions struct {
ID string `json:"id"`
Type string `json:"type"`
Status string `json:"status,omitempty"`
Priority *APIReference `json:"priority,omitempty"`
Assignments []Assignee `json:"assignments,omitempty"`
}

The reason I ask is that I have permission to review and merge the PRs of others, and not my own, so an external contribution is easier for me to shepherd towards release.

@theckman theckman added help wanted open question there is an open question on the issue / PR labels Feb 20, 2021
@theckman theckman added this to the v1.4.0 milestone Feb 20, 2021
@theckman
Copy link
Collaborator

@hagaishapira I went ahead and raised a PR since I didn't hear back from you. Your request should make it as part of v1.4.0 when it's eventually released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted open question there is an open question on the issue / PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants