fix: fix pluginPackages type #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamimkh
force-pushed
the
fix/correct-plugin-packages-type
branch
from
e0c8b7b to
eaaf76f
Compare
The value of `backstage.pluginPackages` is incorrectly set to `pluginId` when it is supposed to represent an array of all the packages that are a part of this plugin. This commit corrects this value to be an array and fixes an issue that prevents the installation of this plugin on certain backstage installations Signed-off-by: Tamim Khan <tamim@pagerduty.com>
tamimkh
force-pushed
the
fix/correct-plugin-packages-type
branch
from
eaaf76f to
f27f2a7
Compare
jdppettit
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The value of
backstage.pluginPackageswas incorrectly set topluginIdwhen it is supposed to represent all the packages that are a part of this plugin. This PR corrects this value and fixes an issue that prevents this plugin from being installed on certain backstage installations.Issue number: N/A
Type of change
Checklist
If this is a breaking change 👇
Acknowledgement
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.