Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin doesn't refresh from search #54

Closed
shmaram opened this issue Jan 3, 2024 · 4 comments
Closed

Plugin doesn't refresh from search #54

shmaram opened this issue Jan 3, 2024 · 4 comments
Assignees
@t1agob
Labels
bug Something isn't working high priority High priority issue

Comments

@shmaram
Copy link

shmaram commented Jan 3, 2024

Describe the bug
When searching from the Backstage search modal the data of the plugin doesn't refresh

To Reproduce
Steps to reproduce the behavior:

  1. Go to an entity that uses the plugin, you should see the PD data of that service (in the example - "acc")
    image
  2. Click on the "search" from the left pane
    image
  3. You should see the search modal
  4. select a different service from the modal data
  5. Look at the PD plugin and see that the data didn't change
    image

Expected behavior
After clicking on a different service, the PD data should refresh

Screenshots
Added in the steps above

Desktop (please complete the following information):

  • OS: Mac Sonoma 14.2.1
  • Browser Chrome
  • Version 120.0.6099.129

Additional context
We are connecting the PD plugin using the annotation pagerduty.com/service-id and the package is using EntityPagerDutyCard from @pagerduty/backstage-plugin version: 0.7.3
@shmaram shmaram added the bug Something isn't working label Jan 3, 2024
@t1agob
Copy link
Contributor

t1agob commented Jan 3, 2024

Thanks for reporting this bug @shmaram. With your detailed reproduction steps I was able to reproduce the bug and will start working on it immediately.

@t1agob t1agob self-assigned this Jan 3, 2024
@t1agob t1agob added the high priority High priority issue label Jan 3, 2024
@t1agob t1agob moved this from Todo to In Progress in PagerDuty plugin for Backstage Jan 4, 2024
@t1agob t1agob mentioned this issue Jan 4, 2024
Merged
10 tasks
@t1agob
Copy link
Contributor

t1agob commented Jan 4, 2024

@shmaram just to let you know that I've identified and fixed the issue reported yesterday (PR #55).

I'm working on getting this merged into main and release ASAP. I'll notify you here once it is done.

t1agob added a commit that referenced this issue Jan 4, 2024
@t1agob
fix: component now refreshes when navigating from search (#55)
0705cd5 
### Description

This PR fixes the issue reported in #54. 

A problem with React hooks dependency setup led to the component not
refreshing itself when users leveraged the search capability to navigate
between components.

**Issue number:** #54

### Type of change

- [ ] New feature (non-breaking change which adds functionality)
- [x] Fix (non-breaking change which fixes an issue)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)

### Checklist

- [x] I have performed a self-review of this change
- [x] Changes have been tested
- [ ] Changes are documented
- [x] Changes generate *no new warnings*
- [x] PR title follows [conventional commit
semantics](https://www.conventionalcommits.org/en/v1.0.0/)

If this is a breaking change 👇

- [ ] I have documented the migration process
- [ ] I have implemented necessary warnings (if it can live side by
side)

## Acknowledgement

By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.

**Disclaimer:** We value your time and bandwidth. As such, any pull
requests created on non-triaged issues might not be successful.
@t1agob t1agob mentioned this issue Jan 4, 2024
Merged
t1agob added a commit that referenced this issue Jan 4, 2024
@t1agob
release: 0.7.4 (#56)
ac838e7 
### Description

This release includes a fix to a bug (#54) that prevented the
PagerDutyCard from refreshing when users leveraged the Backstage search
to navigate between components.

## Acknowledgement

By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.

**Disclaimer:** We value your time and bandwidth. As such, any pull
requests created on non-triaged issues might not be successful.
@t1agob t1agob moved this from In Progress to Done in PagerDuty plugin for Backstage Jan 4, 2024
@t1agob
Copy link
Contributor

t1agob commented Jan 4, 2024

This issue is now fixed and available on version 0.7.4. Thanks for reporting it @shmaram!

@t1agob t1agob closed this as completed Jan 4, 2024
@shmaram
Copy link
Author

shmaram commented Jan 4, 2024

Just check and it works like a charm!
Thank you @t1agob for the fast response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t1agob t1agob

Labels
bug Something isn't working high priority High priority issue
Projects
PagerDuty plugin for Backstage
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@t1agob @shmaram