[Remove] 代码检查移交给 Paddle CI #6129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
SigureMo
reviewed
Aug 24, 2023
docs/api/gen_doc.py
Outdated
| @@ -1545,15 +1305,10 @@ def parse_args(): | |||
| gen_en_files() | |||
| check_cn_en_match() | |||
| if need_run_sample_codes: | |||
There was a problem hiding this comment.
这个参数感觉也可以直接删了，现在有 CI 会传入 --need-run-sample-codes 或者环境变量 RUN_SAMPLE_CODES 嘛？
看样子这些参数应该都可以删了
--run-sample-codes和环境变量RUN_SAMPLE_CODES--threads和环境变量RUN_SAMPLE_CODES_THREADS--run-on-device--gpu_id
相关用到的代码应该也是可以清理的，这样 gen_doc.py 应该可以大幅瘦身，毕竟原来承担了太多它不应该承担的职能，也没人能维护的起来……修改后应该会好很多（虽然还是全 Paddle 最烂的代码）
SigureMo
reviewed
Aug 24, 2023
docs/api/gen_doc.py
Outdated
|
|
||
| return "\n".join(codeblock_clean) | ||
|
|
||
|
|
||
| def extract_code_blocks_from_docstr(docstr, google_style=True): |
There was a problem hiding this comment.
extract_code_blocks_from_docstr 是否可以迁移到 docs/api/copy_codes_from_en_doc.py 了呢？
There was a problem hiding this comment.
感觉里面类似 cb_required_pat 这种旧格式才需要的逻辑也可以清理掉了，Paddle repo 是不是有同样的逻辑，应该也是可以清理的？（如果觉得这个 PR 改动太多，我们可以在下一个 PR 再处理也可以，渐进式修改可以减少出问题的概率）
SigureMo
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
中国软件开源创新大赛：飞桨框架任务挑战赛
赛题五：将 xdoctest 引入到飞桨框架工作流中
RFC [Add]将 xdoctest 引入到飞桨框架工作流中v1
ISSUE 赛题五：将 xdoctest 引入到飞桨框架工作流中 Tracking Issue
第二阶段
任务：代码检查移交
将 docs 中关于代码检查的代码全部删除。
涉及文件：
ci_scripts/check_api_cn.sh删除掉检查部分ci_scripts/chinese_samplecode_processor.py删除此文件docs/api/gen_doc.py删除掉检查部分关联 PR：PaddlePaddle/Paddle#56573
@SigureMo @luotao1 @jzhang533 @sunzhongkai588
请评审，谢谢！：）