Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rfc] add paddle third_party #524

Closed
wants to merge 2 commits into from
Closed

[rfc] add paddle third_party #524

wants to merge 2 commits into from

Conversation

gouzil
Copy link
Member

@gouzil gouzil commented Apr 25, 2023

为 paddle 主框架添加 third_party 目录用于存放通用第三方库, 减少编译时 git clone的时间, 这部分主要是针对国内网不好的情况进行优化

@paddle-bot
Copy link

paddle-bot bot commented Apr 25, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请检查PR提交格式和内容是否完备,具体请参考示例模版
Your PR has been submitted. Thanks for your contribution!
Please check its format and content. For this, you can refer to Template and Demo.

@jzhang533
Copy link
Collaborator

@risemeup1 is also working on this.

@gouzil
Copy link
Member Author

gouzil commented Apr 26, 2023

研发大哥怎么说,可以开始了吗,应该还需要调整一下ci

@risemeup1
Copy link
Contributor

研发大哥怎么说,可以开始了吗,应该还需要调整一下ci

这个已经开始干了,差不多快搞完了。等我们开会在讨论下要不要用外部开发者做

@risemeup1
Copy link
Contributor

研发大哥怎么说,可以开始了吗,应该还需要调整一下ci

这个已经开始干了,差不多快搞完了。等我们开会在讨论下要不要用外部开发者做

现在还存在很多其他问题,例如很多第三方库不是放在github或者gitlab上的,是放在bos上的一些压缩包文件,这些是使用不了submodule的

@gouzil
Copy link
Member Author

gouzil commented Apr 26, 2023

研发大哥怎么说,可以开始了吗,应该还需要调整一下ci

这个已经开始干了,差不多快搞完了。等我们开会在讨论下要不要用外部开发者做

现在还存在很多其他问题,例如很多第三方库不是放在github或者gitlab上的,是放在bos上的一些压缩包文件,这些是使用不了submodule的

是的,我考虑到了,所以只迁移部分通用的第三方库

@gouzil
Copy link
Member Author

gouzil commented Apr 26, 2023

另外,因为ci的环境都比较固定,所以可以考虑先引入, 本地库搜索, 也就是FindXXX部分

@risemeup1
Copy link
Contributor

另外,因为ci的环境都比较固定,所以可以考虑先引入, 本地库搜索, 也就是FindXXX部分

是的,考虑到了,其实CI有时候代理也不稳定,只是相对比较稳定,这是个好主意

@gouzil
Copy link
Member Author

gouzil commented May 18, 2023

已由 PaddlePaddle/Paddle#53744 实现 submodule 部分, FindXXX部分等研发大哥发任务吧

@paddle-bot
Copy link

paddle-bot bot commented May 18, 2023

很抱歉,经过我们的反复讨论,你的PR暂未达到合入标准,请阅读飞桨社区贡献指南,你可以重新提交新的PR,我们先将此PR关闭,感谢你的贡献。
Sorry to inform you that through our discussion, your PR fails to meet the merging standard (Reference: Paddle API Design Standard Doc). You can also submit an new one. Thank you.

@risemeup1
Copy link
Contributor

已由 PaddlePaddle/Paddle#53744 实现 submodule 部分, FindXXX部分等研发大哥发任务吧

好的

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants