Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Hackathon 4th No.4】 为 Paddle 新增 Trapezoid API #457

Closed
wants to merge 1 commit into from
Closed

Conversation

cos43
Copy link
Contributor

@cos43 cos43 commented Mar 14, 2023

上传开发文档

@paddle-bot
Copy link

paddle-bot bot commented Mar 14, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请检查PR提交格式和内容是否完备,具体请参考示例模版
Your PR has been submitted. Thanks for your contribution!
Please check its format and content. For this, you can refer to Template and Demo.

@cos43
Copy link
Contributor Author

cos43 commented Mar 14, 2023

你的PR提交成功,感谢你对开源项目的贡献! 请检查PR提交格式和内容是否完备,具体请参考示例模版。 Your PR has been submitted. Thanks for your contribution! Please check its format and content. For this, you can refer to Template and Demo.

#457

@luotao1
Copy link
Collaborator

luotao1 commented Mar 14, 2023

该 API 已有提案通过,可以在其提案基础上进行开发,如果其提案有问题,就在提案上直接修改

1033befcdefec424e3e70b5ef9386993

@cos43
Copy link
Contributor Author

cos43 commented Mar 14, 2023

如果按照他的文档继续开发的话,那我后面直接提交代码吗,还需要提交什么呢

@luotao1
Copy link
Collaborator

luotao1 commented Mar 14, 2023

对的,直接提交代码。同时请注意下该任务已经提交作品了。

@cos43
Copy link
Contributor Author

cos43 commented Mar 14, 2023

对的,直接提交代码。同时请注意下该任务已经提交作品了。
好的谢谢,那我还可以继续提交吗?我提交的话还算一次开源贡献吗?

@luotao1
Copy link
Collaborator

luotao1 commented Mar 14, 2023

我提交的话还算一次开源贡献吗?

请问是北邮网安学院么?以你们学院的要求为准。

@cos43
Copy link
Contributor Author

cos43 commented Mar 14, 2023

我提交的话还算一次开源贡献吗?

请问是北邮网安学院么?以你们学院的要求为准。
————————————————————————————————————
谢谢回复,是北邮网安学院的,请问后面继续提交代码的话,还会被被采纳吗,还可以当成一次开源贡献吗

@luotao1
Copy link
Collaborator

luotao1 commented Mar 14, 2023

如果还是这道题的话,采纳的概率比较小

@cos43 cos43 closed this by deleting the head repository Mar 14, 2023
@paddle-bot
Copy link

paddle-bot bot commented Mar 14, 2023

很抱歉,经过我们的反复讨论,你的PR暂未达到合入标准,请阅读飞桨社区贡献指南,你可以重新提交新的PR,我们先将此PR关闭,感谢你的贡献。
Sorry to inform you that through our discussion, your PR fails to meet the merging standard (Reference: Paddle API Design Standard Doc). You can also submit an new one. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants