-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【Hackathon 4th No.15】Add GaussianNLLLoss rfc file. #372
Conversation
2. 测试 CPU、GPU 上与 numpy 的一致性。 | ||
3. 各reduction下计算一致 | ||
4. 各参数输入有效。 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
补充可行性分析和排期规划
# 一、概述 | ||
|
||
## 1、相关背景 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
补充一下loss计算公式
@@ -0,0 +1,180 @@ | |||
# xlogy 设计文档 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
变更为paddle.nn.gaussian_nll_loss 设计文档
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已修改
reduction: str="mean", | ||
name:str=None, | ||
) -> Tensor:` | ||
- Input(Tensor): `(N, *)` 或 `(*)` 其中 `*`表示任何数量的额外维度 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
补充各个参数代表的实际意义
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已补充
3. 根据 `reduction`,输出 loss(同其余 functional loss 中的实现) | ||
|
||
|
||
# 六、测试和验收的考量 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里增加对不同数据类型的测试,明确该 loss 支持的输入数据类型和输出数据类型
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add GaussianNLLLoss rfc file.
代码及英文文档:PaddlePaddle/Paddle#50843
中文文档:PaddlePaddle/docs#5623