Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eslint clean up #369

Merged
merged 7 commits into from
Apr 7, 2018
Merged

Eslint clean up #369

merged 7 commits into from
Apr 7, 2018

Conversation

jetfuel
Copy link
Collaborator

@jetfuel jetfuel commented Apr 6, 2018

This PR should conclude the need of #364

I did, however, turn off the check for the follow checks

    'no-invalid-this': 'off',
    'require-jsdoc': 'off',
    'no-unused-vars': 'off',

One is Javascript function documentation requirement. Turning it on might be overkill, but we should be vigilant to provide better documentaitons

The other two checks are related to debounce functions. ESLint can't parse them properly so I had to show them down until I find a better solution.

@jetfuel jetfuel self-assigned this Apr 6, 2018
@daming-lu daming-lu merged commit 0be5b06 into PaddlePaddle:develop Apr 7, 2018
@jetfuel jetfuel deleted the eslint_clean_up branch April 9, 2018 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants