Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eslint precommit #368

Merged
merged 5 commits into from
Apr 6, 2018
Merged

Eslint precommit #368

merged 5 commits into from
Apr 6, 2018

Conversation

jetfuel
Copy link
Collaborator

@jetfuel jetfuel commented Apr 6, 2018

This is the phrase 2 of the #364 PR

In this PR, we set up the pre-commit hook (Currently comment out) for future usage.
We set the script ident to 2
We will enforce camelCase from now on.

All the changes here are done automatically. I will create another PR to include manual changes later to improve review-ability.

@jetfuel jetfuel self-assigned this Apr 6, 2018
@jetfuel jetfuel merged commit 6dfa1d4 into PaddlePaddle:develop Apr 6, 2018
@jetfuel jetfuel deleted the eslint_precommit branch April 6, 2018 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants