Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide instructions on virtualenv. #258

Merged
merged 2 commits into from
Feb 6, 2018
Merged

Provide instructions on virtualenv. #258

merged 2 commits into from
Feb 6, 2018

Conversation

jetfuel
Copy link
Collaborator

@jetfuel jetfuel commented Feb 5, 2018 •
edited
Loading

@jetfuel jetfuel self-assigned this Feb 5, 2018
varunarora
varunarora reviewed Feb 5, 2018
View reviewed changes
README.cn.md
pip install --upgrade visualdl

# 运行一个例子
# 运行一个例子，vdl_scratch.py将创建测试日志
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

运行一个例子?

varunarora
varunarora reviewed Feb 5, 2018
View reviewed changes
README.md
@@ -62,11 +62,14 @@ Histogram can be used to visualize parameter distribution and trends for any ten
</p>

## Quick Start
To give the VisualDL a quick test, please use the following commands.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So instead of this, why don't we just give them a simple command "virtualenv venv; source venv/bin/activate`. This requires them to go read another doc and figure out how virtualenv works. What do you think?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah just saw your stuff for contrib. I'd just add those lines here too and avoid the confusiuon.

docs/contribute_code_cn.md

```bash
pip install --upgrade virtualenv
virtualenv YOUR_VIRTUAL_EVN_FOLDER
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes yes yes!!

@jetfuel jetfuel merged commit 4da4825 into PaddlePaddle:develop Feb 6, 2018
@jetfuel jetfuel deleted the updateREADME branch February 6, 2018 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varunarora varunarora varunarora approved these changes

Assignees

@jetfuel jetfuel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jetfuel @varunarora