[ASR] whisper fix language choice, test=asr #2828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
cxumol
changed the title
yt605155624
reviewed
Jan 12, 2023
| @@ -476,7 +476,7 @@ def transcribe( | |||
| decode_options["fp16"] = False | |||
|
|
|||
| if decode_options.get( | |||
| "language", 'None') or decode_options.get("language", None) is None: | |||
| "language") == 'None' or decode_options.get("language", None) is None: | |||
There was a problem hiding this comment.
这里直接判断 "language" 是否在 decode_options 的 keys 里面就行吧？
There was a problem hiding this comment.
不行的, 因为如果用户未指定语种, 他可以按这样传入的参数
whisper_executor(language=None, *args)那么 "language" 就会出现在 decode_options 的 keys 里面, 所以不能根据 "language" 在不在 decode_options 的 keys 里面来判断
下面是概念验证
zxcd
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Describe
fix #2827
Reference https://docs.python.org/3/library/stdtypes.html#dict.get