This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
[opcode][3.11] support CALL_FUNCTION_EX in py311
#362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
…ort_RETURN_VALUE_py311 # Conflicts: # tests/run_all.sh
zrr1999
reviewed
Aug 31, 2023
Comment on lines
2200
to
2201
| if len(self.stack) == 1 and isinstance(self.stack.peek(), NullVariable): | ||
| self.stack.pop() |
There was a problem hiding this comment.
目前这个测试来看的话是只有LOAD_GLOBAL会
There was a problem hiding this comment.
但是理论上所有LOAD_GLOBAL出来的null在CALL的时候就应该已经被移除了，RETURN这里应该就没有了，如果还有的话感觉应该是哪里还有些问题
There was a problem hiding this comment.
从这个单测来看的话没调用CALL, 应该是这其中的某个也需要pop
[transform] OriginCode: build_tuple_unpack_with_call
31 0 RESUME 0
34 2 LOAD_GLOBAL 1 (NULL + build_tuple_unpack_with_call_inner)
14 BUILD_LIST 0
16 LOAD_FAST 0 (x)
18 LIST_EXTEND 1
20 LOAD_FAST 1 (y)
22 LIST_EXTEND 1
24 LIST_TO_TUPLE
26 CALL_FUNCTION_EX 0
28 STORE_FAST 2 (z)
35 30 LOAD_FAST 2 (z)
32 LOAD_CONST 1 (0)
34 BINARY_SUBSCR
44 LOAD_CONST 2 (1)
46 BINARY_OP 0 (+)
50 RETURN_VALUEThere was a problem hiding this comment.
应该要在CALL_FUNCTION_EX下做pop的，写错了
SigureMo
approved these changes
Aug 31, 2023
gouzil
changed the title
CALL_FUNCTION_EX in py311
zrr1999
approved these changes
Aug 31, 2023
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
相关任务：任务 1
单测状态变化：
test_10_build_unpack.py❌ -> ✅