This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
[CRC] add docstring for opcode executor #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Aurelius84
reviewed
Jun 28, 2023
| @@ -205,9 +283,18 @@ def inner(self: OpcodeExecutorBase, instr: Instruction): | |||
|
|
|||
|
|
|||
| def jump_break_graph_decorator(normal_jump): | |||
| """breakoff graph when meet jump.""" | |||
| """ | |||
| A decorator function that breaks off the graph when a jump instruction is encountered. | |||
There was a problem hiding this comment.
Suggested change
| A decorator function that breaks off the graph when a jump instruction is encountered. | |
| A decorator function that breaks off the graph when a JUMP-related instruction is encountered. |
| def decorate(call_fn): | ||
| def call_break_graph_decorator(push_n: int): | ||
| """ | ||
| A decorator function that breaks off the graph when a function call instruction is encountered. |
There was a problem hiding this comment.
Suggested change
| A decorator function that breaks off the graph when a function call instruction is encountered. | |
| A decorator function that breaks off the graph when a function CALL instruction is encountered. |
|
|
||
| The OpcodeExecutorBase class provides methods and functionality to execute opcode instructions. | ||
|
|
||
| If you want to learn more about Python instructions, you can visit https://docs.python.org/3/library/dis.html |
There was a problem hiding this comment.
Suggested change
| If you want to learn more about Python instructions, you can visit https://docs.python.org/3/library/dis.html | |
| If you want to learn more about Python instructions, see https://docs.python.org/3/library/dis.html for details. |
| raise NotImplementedError() | ||
|
|
||
| def transform(self): | ||
| """ | ||
| Transforms the executor. |
There was a problem hiding this comment.
Suggested change
| Transforms the executor. | |
| Abstract method need to be implemented to symbolic translate each instruction. |
| self, origin_stack: list[VariableBase], instr: Instruction, push_n: int | ||
| ): | ||
| """ | ||
| Break the graph at a call instruction. |
There was a problem hiding this comment.
Suggested change
| Break the graph at a call instruction. | |
| Break the graph at a CALL instruction. |
| def _break_graph_in_jump(self, result, instr): | ||
| def _break_graph_in_jump(self, result: VariableBase, instr: Instruction): | ||
| """ | ||
| Break the graph at a jump instruction. |
There was a problem hiding this comment.
Suggested change
| Break the graph at a jump instruction. | |
| Break the graph at a JUMP instruction. |
| def _break_graph_in_jump(self, result, instr): | ||
| def _break_graph_in_jump(self, result, instr: Instruction): | ||
| """ | ||
| Breaks the graph in jump instructions. |
There was a problem hiding this comment.
Suggested change
| Breaks the graph in jump instructions. | |
| Breaks the graph in JUMP instructions. |
SigureMo
reviewed
Jun 29, 2023
Co-authored-by: Nyakku Shigure <sigure.qaq@gmail.com>
Aurelius84
approved these changes
Jun 29, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.