Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PyLayer version of Recompute #6885

Merged
merged 3 commits into from
Aug 31, 2023

Conversation

sijunhe
Copy link
Collaborator

@sijunhe sijunhe commented Aug 31, 2023

PR types

PR changes

Description

This pr: PaddlePaddle/Paddle#56793 fix llama generation bug under pylayer version recompute.

@paddle-bot
Copy link

paddle-bot bot commented Aug 31, 2023

Thanks for your contribution!

@sijunhe sijunhe requested review from ZHUI and FeixLiu August 31, 2023 06:23
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #6885 (bdad639) into develop (a5626f0) will increase coverage by 0.00%.
Report is 1 commits behind head on develop.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #6885   +/-   ##
========================================
  Coverage    59.94%   59.94%           
========================================
  Files          547      547           
  Lines        80996    81001    +5     
========================================
+ Hits         48550    48553    +3     
- Misses       32446    32448    +2     
Files Changed Coverage Δ
paddlenlp/transformers/chatglm/modeling.py 72.96% <ø> (ø)
paddlenlp/transformers/gpt/modeling.py 66.30% <ø> (ø)
paddlenlp/transformers/bloom/modeling.py 56.34% <100.00%> (+0.05%) ⬆️
paddlenlp/transformers/chatglm_v2/modeling.py 86.82% <100.00%> (+0.03%) ⬆️
paddlenlp/transformers/configuration_utils.py 72.48% <100.00%> (+0.06%) ⬆️
paddlenlp/transformers/llama/modeling.py 68.51% <100.00%> (+0.04%) ⬆️
paddlenlp/transformers/qwen/modeling.py 86.05% <100.00%> (+0.03%) ⬆️

... and 1 file with indirect coverage changes

@sijunhe sijunhe merged commit f443bae into PaddlePaddle:develop Aug 31, 2023
@sijunhe sijunhe deleted the recompute_pylayer branch August 31, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants