fix error in types and cancel dir pkg under dir go #587
Conversation
| Image string `json:"image,omitempty"` | ||
| Image string `json:"image,omitempty"` | ||
| // If you want to use the hostnetwork instead of container network | ||
| // portmanager is necessary. |
There was a problem hiding this comment.
Do we have a link to introduce the portmanager? The user may not know what's a portmanager is.
There was a problem hiding this comment.
@Yancey1989 ok, let me add a link
| @@ -31,7 +31,7 @@ echo ${CODEGEN_PKG} | |||
| # k8s.io/kubernetes. The output-base is needed for the generators to output into the vendor dir | |||
| # instead of the $GOPATH directly. For normal projects this can be dropped. | |||
| ${CODEGEN_PKG}/generate-groups.sh "deepcopy,client,informer,lister" \ | |||
| github.com/PaddlePaddle/cloud/go/pkg/client github.com/PaddlePaddle/cloud/go/pkg/apis \ | |||
| github.com/PaddlePaddle/cloud/go/client github.com/PaddlePaddle/cloud/go/apis \ | |||
There was a problem hiding this comment.
I see no go/pkg/client directory in current develop branch, is this really needed? Or can you add this when the package is committed.
There was a problem hiding this comment.
@typhoonzero dir client will be generated for go test
There was a problem hiding this comment.
And I think it is strange only to change pkg/apis.
There was a problem hiding this comment.
I see, is generate-groups.sh "deepcopy,client,informer,lister" generating the template code for later development?
There was a problem hiding this comment.
Yes, if the structs of types change, the tools (client, deepcopy and so on) need to be re-generated.
This is a sub pr of pr #565
reorganize the structure of project.